Improve fps counter

[GabrielNakamoto]

Accumulate it over a few frames to give an average instead of showing the last frame performance only

• In vtkF3DUIActor I changed SetFpsValue() to UpdateFpsValue() which will automatically accumulate fps values before setting the display value to the average. The number of frames it waits to average is decided by the static member variable vtkF3DUIActor::FramesToAverage

Updating it only when the whole scene is rendered

• In the vtkF3DRenderer::Render() function I updated it to check if its information has vtkF3DRenderPass::RENDER_UI_ONLY() set to 1 If it does it calculates the fps value and calls the UI Actor's UpdateFpsValue()

Let me know what you think the number of frames to average should be (currently set to 5).

From building it and using some of the example models it seems that the render UI only is working however I may be wrong.

Seeing this is my first time contributing I'm starting a pull request to get some advice.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.71%. Comparing base (91310bd) to head (fd30857).
Report is 34 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1886      +/-   ##
==========================================
+ Coverage   95.69%   95.71%   +0.01%     
==========================================
  Files         125      125              
  Lines        9926     9970      +44     
==========================================
+ Hits         9499     9543      +44     
  Misses        427      427              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mwestphal]

This is looking good, wdyt @Meakk ?

[GabrielNakamoto]

I don't think the last commit works but I don't know why?

[Meakk]

Great! Thank you for your contribution!

[mwestphal]

please convert all tabs to space

[Meakk]

please convert all tabs to space

Why is clang-format not detecting that?

[mwestphal]

please convert all tabs to space

Why is clang-format not detecting that?

no idea, to improve definitely

[GabrielNakamoto]

I pushed the style changes

[mwestphal]

Suggested change

	glEndQuery(GL_TIME_ELAPSED);
	GLint elapsed;
	glGetQueryObjectiv(this->Timer, GL_QUERY_RESULT, &elapsed);
	glEndQuery(GL_TIME_ELAPSED);
	GLint elapsed;
	glGetQueryObjectiv(this->Timer, GL_QUERY_RESULT, &elapsed);

[mwestphal]

Suggested change

	// Get CPU frame time
	double elapsedTime = std::chrono::duration_cast<std::chrono::microseconds>(cpuElapsed).count() * 1e-6;
	// Get CPU frame time
	double elapsedTime = std::chrono::duration_cast<std::chrono::microseconds>(cpuElapsed).count() * 1e-6;

[mwestphal]

Suggested change

	// Get min between CPU frame time and GPU frame time
	elapsedTime = std::min(elapsedTime, elapsed * 1e-9);
	// Get min between CPU frame time and GPU frame time
	elapsedTime = std::min(elapsedTime, elapsed * 1e-9);

[mwestphal]

Suggested change

	this->UIActor->UpdateFpsValue(elapsedTime);
	this->UIActor->UpdateFpsValue(elapsedTime);

[mwestphal]

still incorrect indenting, sorrt about that

[Meakk]

Let's merge it. Formatting will be handle in #1912

[Meakk]

Thanks @GabrielNakamoto!