Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve clang-format #1912

Merged
merged 2 commits into from
Jan 13, 2025
Merged

Improve clang-format #1912

merged 2 commits into from
Jan 13, 2025

Conversation

Meakk
Copy link
Member

@Meakk Meakk commented Jan 12, 2025 •
edited
Loading

  • Added missing folders
  • Upgrade to version 18
  • Made related changes

@Meakk Meakk self-assigned this Jan 12, 2025
@github-actions GitHub Actions
Copy link

You are modifying libf3d public API! ⚠️Please update bindings accordingly⚠️!
You can find them in their respective directories: python, java, webassembly.

@Meakk Meakk requested a review from mwestphal January 12, 2025 16:58
@codecov Codecov
Copy link

codecov bot commented Jan 12, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 77.87611% with 25 lines in your changes missing coverage. Please review.

Project coverage is 95.62%. Comparing base (b134d54) to head (64eb9d9).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
vtkext/private/module/vtkF3DUIActor.h 0.00% 20 Missing ⚠️
...t/private/module/vtkF3DInteractorEventRecorder.cxx 70.00% 3 Missing ⚠️
vtkext/private/module/vtkF3DUIObserver.h 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1912      +/-   ##
==========================================
- Coverage   95.69%   95.62%   -0.08%     
==========================================
  Files         125      125              
  Lines        9997    10013      +16     
==========================================
+ Hits         9567     9575       +8     
- Misses        430      438       +8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Meakk Meakk mentioned this pull request Jan 12, 2025
Merged
@Meakk Meakk force-pushed the improve-clang-format branch from 6295157 to 7b42691 Compare January 12, 2025 21:01
@Meakk Meakk force-pushed the improve-clang-format branch from 7b42691 to a94fe74 Compare January 12, 2025 21:04
mwestphal
mwestphal requested changes Jan 12, 2025
View reviewed changes
Copy link
Contributor

@mwestphal mwestphal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small change needed

@Meakk Meakk merged commit 8d72f2d into f3d-app:master Jan 13, 2025
47 of 48 checks passed
@Meakk Meakk deleted the improve-clang-format branch January 13, 2025 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwestphal mwestphal mwestphal approved these changes

Assignees

@Meakk Meakk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Meakk @mwestphal