Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2): fix input losing focus on init #2188

Merged
merged 2 commits into from
Jan 8, 2020

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented Jan 4, 2020

Motivation

A continuation of #2178 and resolve #2175

Fix for loss of focus in search input on all screens. Moreover, this PR fixes Algolia loading on screens up to 360px, currently the search on these screens did not work 😢

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

  1. Load Netlify preview (try on mobile too)
  2. Click on the search bar
  3. See that it doesn't lose focus

@lex111 lex111 requested a review from yangshun January 4, 2020 18:45
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jan 4, 2020
@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Jan 4, 2020

Deploy preview for docusaurus-2 ready!

Built with commit 5a1c1d9

https://deploy-preview-2188--docusaurus-2.netlify.com

Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on mobile and desktop. You rock Alexey ⭐️

@yangshun yangshun merged commit 5252111 into facebook:master Jan 8, 2020
@lex111 lex111 added the pr: bug fix This PR fixes a bug in a past release. label Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(v2): search bar loses focus after clicking on it after initial load
4 participants