fix(v2): remove focus on search input when hovering over it #2262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lex111
commented
Feb 1, 2020
| @@ -87,8 +94,8 @@ const Search = props => { | |||
| className={classnames('search-icon', { | |||
| 'search-icon-hidden': props.isSearchBarExpanded, | |||
| })} | |||
| onClick={toggleSearchIconClick} | |||
| onKeyDown={toggleSearchIconClick} | |||
| onClick={handleSearchIcon} | |||
There was a problem hiding this comment.
Rename handler for consistency.
lex111
commented
Feb 1, 2020
| @@ -77,7 +78,13 @@ const Search = props => { | |||
|
|
|||
| const handleSearchInputBlur = useCallback(() => { | |||
| props.handleSearchBarToggle(!props.isSearchBarExpanded); | |||
| }, [algoliaLoaded]); | |||
| }, [props.isSearchBarExpanded]); | |||
There was a problem hiding this comment.
Fix also proper deps.
|
Deploy preview for docusaurus-2 ready! Built with commit 4b8ca8e |
yangshun
approved these changes
Feb 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
PR #2188 brought an unpleasant side effect - when you hover over the search field, auto focus occurred on this field.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Check the search input work - when hovering, when focus, also consider mobiles.
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)