-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(v2): fix title logic (meta vs heading) + ignore fixed anchor id syntax #4688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r + add useful todo
…r + add useful todo
=> we are not supposed to create anchor links for h1 headers
[V1] Built with commit 5354b3a |
[V2] Built with commit 5354b3a |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-4688--docusaurus-2.netlify.app/ |
Size Change: 0 B Total Size: 631 kB ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #4665 (comment) + handle fixed anchor syntax
Keep behavior we had before:
frontmatter.title
controls page meta in priority# title
controls page h1 heading in priorityWe should rather not use fixed anchor ids syntax on top level h1 headings, as user should not use h1 headings in his doc normally anyway:
writeHeadingIds
cli will not write custom anchor ids for h1 md titles, and# myTitle
remains untouched# myTitle {#my-anchor}
will now parse correctlytitle = myTitle
Have you read the Contributing Guidelines on pull requests?
yes
Test Plan
test