Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(v2): fix title logic (meta vs heading) + ignore fixed anchor id syntax #4688

Merged
merged 8 commits into from
Apr 27, 2021
Merged

fix(v2): fix title logic (meta vs heading) + ignore fixed anchor id syntax #4688

merged 8 commits into from
Apr 27, 2021

Commits on Apr 27, 2021

  1. parseMarkdownContentTitle should ignore {#my-anchor-id} syntax

    @slorber
    slorber committed Apr 27, 2021
    Configuration menu
    Copy the full SHA
    aa04be0 View commit details
    Browse the repository at this point in the history

  2. use frontMatter.title in priority for page meta title

    @slorber
    slorber committed Apr 27, 2021
    Configuration menu
    Copy the full SHA
    c91d369 View commit details
    Browse the repository at this point in the history

  3. parseMarkdownString should ignore fixed anchor ids syntax

    @slorber
    slorber committed Apr 27, 2021
    Configuration menu
    Copy the full SHA
    c6cf773 View commit details
    Browse the repository at this point in the history

  4. docs: make the distinction between headingTitle + metaTitle more clea… 

    …r + add useful todo
    @slorber
    slorber committed Apr 27, 2021
    Configuration menu
    Copy the full SHA
    55cc622 View commit details
    Browse the repository at this point in the history

  5. docs: make the distinction between headingTitle + metaTitle more clea… 

    …r + add useful todo
    @slorber
    slorber committed Apr 27, 2021
    Configuration menu
    Copy the full SHA
    ada6369 View commit details
    Browse the repository at this point in the history

  6. writeHeadingIds should ignore top-level md title like "# Title" 

    => we are not supposed to create anchor links for h1 headers
    @slorber
    slorber committed Apr 27, 2021
    Configuration menu
    Copy the full SHA
    45746c4 View commit details
    Browse the repository at this point in the history

  7. update tests

    @slorber
    slorber committed Apr 27, 2021
    Configuration menu
    Copy the full SHA
    db101be View commit details
    Browse the repository at this point in the history

  8. fix doc tests

    @slorber
    slorber committed Apr 27, 2021
    Configuration menu
    Copy the full SHA
    5354b3a View commit details
    Browse the repository at this point in the history