Skip to content

Commit

Permalink
Adds native to the list of jest-react-native platforms to fix testing…
Browse files Browse the repository at this point in the history
… with react-relay.

Summary:
See jestjs/jest#2170. Per cpojer's request, bringing this PR to react-native as well.

**Summary**

When using jest with React Native and Relay and recommended default settings, jest throws :
```
    Cannot find module 'react-dom' from 'relayUnstableBatchedUpdates.js'

      at Resolver.resolveModule (node_modules/jest-resolve/build/index.js:151:17)
      at Object.<anonymous> (node_modules/react-relay/lib/relayUnstableBatchedUpdates.js:15:18)
      at new RelayEnvironment (node_modules/react-relay/lib/RelayEnvironment.js:39:63)
```

Investigating this, I found out that https://github.com/facebook/jest/blob/master/packages/jest-react-native/jest-preset.json didn't have "native" in the list of platforms, hence jest can't pick up `relayUnstableBatchedUpdates.native.js` in react-relay.

**Test plan**

I copied and paste the content of https://github.com/facebook/jest/blob/master/packages/jest-react-native/jest-preset.json in my `package.json` `jest` section, as well a
Closes #11179

Differential Revision: D4243073

Pulled By: cpojer

fbshipit-source-id: bcfeb2235df4d466ba19d0a3fe94fc98835a20ea
  • Loading branch information
chollier authored and Facebook Github Bot committed Nov 29, 2016
1 parent 65fe3ea commit 30152ff
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion jest-preset.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"haste": {
"defaultPlatform": "ios",
"platforms": ["android", "ios"],
"platforms": ["android", "ios", "native"],
"providesModuleNodeModules": [
"react-native"
]
Expand Down

0 comments on commit 30152ff

Please sign in to comment.