Adds native to the list of jest-react-native platforms to fix testing with react-relay. #11179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @cpojer and @kentaromiura to be potential reviewers. |
facebook-github-bot
added
GH Review: review-needed
CLA Signed
|
@cpojer has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
robclouth
pushed a commit
to robclouth/react-native
that referenced
this pull request
Dec 7, 2016
… with react-relay. Summary: See jestjs/jest#2170. Per cpojer's request, bringing this PR to react-native as well. **Summary** When using jest with React Native and Relay and recommended default settings, jest throws : ``` Cannot find module 'react-dom' from 'relayUnstableBatchedUpdates.js' at Resolver.resolveModule (node_modules/jest-resolve/build/index.js:151:17) at Object.<anonymous> (node_modules/react-relay/lib/relayUnstableBatchedUpdates.js:15:18) at new RelayEnvironment (node_modules/react-relay/lib/RelayEnvironment.js:39:63) ``` Investigating this, I found out that https://github.com/facebook/jest/blob/master/packages/jest-react-native/jest-preset.json didn't have "native" in the list of platforms, hence jest can't pick up `relayUnstableBatchedUpdates.native.js` in react-relay. **Test plan** I copied and paste the content of https://github.com/facebook/jest/blob/master/packages/jest-react-native/jest-preset.json in my `package.json` `jest` section, as well a Closes facebook#11179 Differential Revision: D4243073 Pulled By: cpojer fbshipit-source-id: bcfeb2235df4d466ba19d0a3fe94fc98835a20ea
DanielMSchmidt
pushed a commit
to DanielMSchmidt/react-native
that referenced
this pull request
Jan 4, 2017
… with react-relay. Summary: See jestjs/jest#2170. Per cpojer's request, bringing this PR to react-native as well. **Summary** When using jest with React Native and Relay and recommended default settings, jest throws : ``` Cannot find module 'react-dom' from 'relayUnstableBatchedUpdates.js' at Resolver.resolveModule (node_modules/jest-resolve/build/index.js:151:17) at Object.<anonymous> (node_modules/react-relay/lib/relayUnstableBatchedUpdates.js:15:18) at new RelayEnvironment (node_modules/react-relay/lib/RelayEnvironment.js:39:63) ``` Investigating this, I found out that https://github.com/facebook/jest/blob/master/packages/jest-react-native/jest-preset.json didn't have "native" in the list of platforms, hence jest can't pick up `relayUnstableBatchedUpdates.native.js` in react-relay. **Test plan** I copied and paste the content of https://github.com/facebook/jest/blob/master/packages/jest-react-native/jest-preset.json in my `package.json` `jest` section, as well a Closes facebook#11179 Differential Revision: D4243073 Pulled By: cpojer fbshipit-source-id: bcfeb2235df4d466ba19d0a3fe94fc98835a20ea
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See jestjs/jest#2170. Per @cpojer's request, bringing this PR to react-native as well.
Summary
When using jest with React Native and Relay and recommended default settings, jest throws :
Investigating this, I found out that https://github.com/facebook/jest/blob/master/packages/jest-react-native/jest-preset.json didn't have "native" in the list of platforms, hence jest can't pick up
relayUnstableBatchedUpdates.native.jsin react-relay.Test plan
I copied and paste the content of https://github.com/facebook/jest/blob/master/packages/jest-react-native/jest-preset.json in my
package.jsonjestsection, as well as removed thepresetentry. Same result.I then did :
This fixes the issue.