Skip to content

Commit

Permalink
Remove some methods that have NS_UNAVAILABLE set (#19790)
Browse files Browse the repository at this point in the history
Summary:
These lines were causing erros with the e2e tests on ios.
There are some methods that are not going to be called, and some definitions that are not correct.

needed for #19574.

we will run the e2e tests.

[INTERNAL] [MINOR] [Tests] - Fix some definitions.
Closes #19790

Differential Revision: D8509228

Pulled By: hramos

fbshipit-source-id: 78650e347db52305a587e3461ac56877e3c79062
  • Loading branch information
Pavlos Vinieratos authored and facebook-github-bot committed Jun 19, 2018
1 parent e11cdc9 commit 5f9a211
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 18 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,6 @@ - (instancetype)initWithBridge:(RCTBridge *)bridge
return self;
}

RCT_NOT_IMPLEMENTED(- (instancetype)initWithFrame:(CGRect)frame)
RCT_NOT_IMPLEMENTED(- (instancetype)initWithCoder:(NSCoder *)coder)

- (id<RCTBackedTextInputViewProtocol>)backedTextInputView
{
return _backedTextInputView;
Expand Down
6 changes: 0 additions & 6 deletions Libraries/Text/TextInput/Multiline/RCTUITextView.m
Original file line number Diff line number Diff line change
Expand Up @@ -108,12 +108,6 @@ - (void)setTextAlignment:(NSTextAlignment)textAlignment
_placeholderView.textAlignment = textAlignment;
}

- (void)setText:(NSString *)text
{
[super setText:text];
[self textDidChange];
}

- (void)setAttributedText:(NSAttributedString *)attributedText
{
[super setAttributedText:attributedText];
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,6 @@ - (instancetype)initWithBridge:(RCTBridge *)bridge
return self;
}

RCT_NOT_IMPLEMENTED(- (instancetype)initWithFrame:(CGRect)frame)
RCT_NOT_IMPLEMENTED(- (instancetype)initWithCoder:(NSCoder *)coder)

- (id<RCTBackedTextInputViewProtocol>)backedTextInputView
{
return _backedTextInputView;
Expand Down
6 changes: 0 additions & 6 deletions Libraries/Text/TextInput/Singleline/RCTUITextField.m
Original file line number Diff line number Diff line change
Expand Up @@ -121,12 +121,6 @@ - (CGRect)editingRectForBounds:(CGRect)bounds

#pragma mark - Overrides

- (void)setSelectedTextRange:(UITextRange *)selectedTextRange
{
[super setSelectedTextRange:selectedTextRange];
[_textInputDelegateAdapter selectedTextRangeWasSet];
}

- (void)setSelectedTextRange:(UITextRange *)selectedTextRange notifyDelegate:(BOOL)notifyDelegate
{
if (!notifyDelegate) {
Expand Down

0 comments on commit 5f9a211

Please sign in to comment.