Remove some methods that have NS_UNAVAILABLE set
#19790
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
pvinis
changed the title
NS_UNAVAILABLE setNS_UNAVAILABLE set
Closed
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Jun 19, 2018
There was a problem hiding this comment.
@hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
macdoum1
pushed a commit
to macdoum1/react-native
that referenced
this pull request
Jun 28, 2018
Summary: These lines were causing erros with the e2e tests on ios. There are some methods that are not going to be called, and some definitions that are not correct. needed for facebook#19574. we will run the e2e tests. [INTERNAL] [MINOR] [Tests] - Fix some definitions. Closes facebook#19790 Differential Revision: D8509228 Pulled By: hramos fbshipit-source-id: 78650e347db52305a587e3461ac56877e3c79062
sidnair
pushed a commit
to taptapsend/react-native
that referenced
this pull request
Aug 2, 2018
Summary: These lines were causing erros with the e2e tests on ios. There are some methods that are not going to be called, and some definitions that are not correct. needed for facebook#19574. we will run the e2e tests. [INTERNAL] [MINOR] [Tests] - Fix some definitions. Closes facebook#19790 Differential Revision: D8509228 Pulled By: hramos fbshipit-source-id: 78650e347db52305a587e3461ac56877e3c79062
sidnair
pushed a commit
to taptapsend/react-native
that referenced
this pull request
Aug 21, 2018
Summary: These lines were causing erros with the e2e tests on ios. There are some methods that are not going to be called, and some definitions that are not correct. needed for facebook#19574. we will run the e2e tests. [INTERNAL] [MINOR] [Tests] - Fix some definitions. Closes facebook#19790 Differential Revision: D8509228 Pulled By: hramos fbshipit-source-id: 78650e347db52305a587e3461ac56877e3c79062
hramos
added
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These lines were causing erros with the e2e tests on ios.
There are some methods that are not going to be called, and some definitions that are not correct.
needed for #19574.
Test Plan
we will run the e2e tests.
Related PRs
#19574
Release Notes
[INTERNAL] [MINOR] [Tests] - Fix some definitions.