-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove @DeprecatedInNewArchitecture annotation from ReactPropGroup #47746
Closed
+0
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
p: Facebook
Partner: Facebook
Partner
labels
Nov 20, 2024
This pull request was exported from Phabricator. Differential Revision: D66216727 |
This pull request was exported from Phabricator. Differential Revision: D66216727 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Nov 21, 2024
…acebook#47746) Summary: Pull Request resolved: facebook#47746 Remove DeprecatedInNewArchitecture annotation from ReactPropGroup since this annotation is not deprecated in new arch changelog: [internal] internal Reviewed By: javache Differential Revision: D66216727
mdvacca
force-pushed
the
export-D66216727
branch
from
November 21, 2024 00:28
ad151af
to
5abaa49
Compare
This pull request was exported from Phabricator. Differential Revision: D66216727 |
…tation (facebook#47745) Summary: Remove DeprecatedInNewArchitecture for ReactPropHolder annotation ReactProp is still used in new arch, we might remove this annotation in the future but it will be independent of new arch changelog: [internal] internal Reviewed By: javache Differential Revision: D66216729
…acebook#47746) Summary: Remove DeprecatedInNewArchitecture annotation from ReactPropGroup since this annotation is not deprecated in new arch changelog: [internal] internal Reviewed By: javache Differential Revision: D66216727
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Nov 22, 2024
…opGroup (facebook#47746) Summary: Remove DeprecatedInNewArchitecture annotation from ReactPropGroup since this annotation is not deprecated in new arch changelog: [internal] internal Reviewed By: javache Differential Revision: D66216727
mdvacca
force-pushed
the
export-D66216727
branch
from
November 22, 2024 17:42
5abaa49
to
c15ae0f
Compare
This pull request was exported from Phabricator. Differential Revision: D66216727 |
This pull request has been merged in 0c47e13. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
fb-exported
Merged
This PR has been merged.
p: Facebook
Partner: Facebook
Partner
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Remove DeprecatedInNewArchitecture annotation from ReactPropGroup since this annotation is not deprecated in new arch
changelog: [internal] internal
Differential Revision: D66216727