Add --no-show-signature to "git show" commands

[stefansundin]

Summary

This fixes errors if the user has configured the following in their ~/.gitconfig:

[log]
showSignature = true

Fixes the following error:

$ cross-env NODE_ENV=production node ./chrome/build
SyntaxError: Unterminated string constant (1:1)

[ ... ]

Unterminated string constant (22:21)
|           context: {
|             surface,
|             version: "4.22.1-gpg: Signature made Thu Dec 23 10:08:56 2021 PST
| gpg:                using RSA key 4AEE18F83AFDEB23
| gpg: Can't check signature: No public key

How did you test this change?

I no longer get the error.

[facebook-github-bot]

Hi @stefansundin!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[sizebot]

Comparing: 3dc41d8...b799cfd

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js	=	129.52 kB	129.52 kB	=	41.53 kB	41.53 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js	=	134.65 kB	134.65 kB	=	43.01 kB	43.01 kB
facebook-www/ReactDOM-prod.classic.js	=	427.76 kB	427.76 kB	=	78.53 kB	78.53 kB
facebook-www/ReactDOM-prod.modern.js	=	417.45 kB	417.45 kB	=	77.06 kB	77.06 kB
facebook-www/ReactDOMForked-prod.classic.js	=	427.76 kB	427.76 kB	=	78.53 kB	78.53 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against b799cfd

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

[bvaughn]

I am not familiar with the "--no-show-signature" flag. It seems like it was added in Git v2.10 (git/git@aa37999). My main concern was that it will seemingly cause older versions of Git to throw ("unrecognized argument") but I guess 2.10 has been out long enough that it's okay for us to add this change.