Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --no-show-signature to "git show" commands #23038

Merged
merged 2 commits into from
Jan 11, 2022
Merged

Add --no-show-signature to "git show" commands #23038

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bf55e0a
Add --no-show-signature to "git show" commands.
stefansundin Dec 28, 2021
b799cfd
yarn prettier-all
stefansundin Dec 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/react-devtools-extensions/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ const GITHUB_URL = 'https://github.com/facebook/react';

function getGitCommit() {
try {
return execSync('git show -s --format=%h')
return execSync('git show -s --no-show-signature --format=%h')
.toString()
.trim();
} catch (error) {
Expand Down
6 changes: 4 additions & 2 deletions scripts/release/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,9 @@ const getBuildInfo = async () => {
const branch = await execRead('git branch | grep \\* | cut -d " " -f2', {
cwd,
});
const commit = await execRead('git show -s --format=%h', {cwd});
const commit = await execRead('git show -s --no-show-signature --format=%h', {
cwd,
});
const checksum = await getChecksumForCurrentRevision(cwd);
const dateString = await getDateStringForCommit(commit);
const version = isExperimental
Expand Down Expand Up @@ -106,7 +108,7 @@ const getChecksumForCurrentRevision = async cwd => {

const getDateStringForCommit = async commit => {
let dateString = await execRead(
`git show -s --format=%cd --date=format:%Y%m%d ${commit}`
`git show -s --no-show-signature --format=%cd --date=format:%Y%m%d ${commit}`
);

// On CI environment, this string is wrapped with quotes '...'s
Expand Down
12 changes: 9 additions & 3 deletions scripts/rollup/build-all-release-channels.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,18 @@ const {
// by configuring an environment variable.

const sha = String(
spawnSync('git', ['show', '-s', '--format=%h']).stdout
spawnSync('git', ['show', '-s', '--no-show-signature', '--format=%h']).stdout
).trim();

let dateString = String(
spawnSync('git', ['show', '-s', '--format=%cd', '--date=format:%Y%m%d', sha])
.stdout
spawnSync('git', [
'show',
'-s',
'--no-show-signature',
'--format=%cd',
'--date=format:%Y%m%d',
sha,
]).stdout
).trim();

// On CI environment, this string is wrapped with quotes '...'s
Expand Down