-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix eden build with python 3.12 #778
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
python 3.12 removes many long deprecated unittest features including _TextTestResult (deprecated in Python 3.2) notices as fedora 39 ships with python 3.12 Test plan: Local build with `./build/fbcode_builder/getdeps.py --allow-system-packages build --src-dir=. eden` Before: ``` FAILED: eden/integration/CMakeFiles/integration_tests.GEN_PY_EXE.util eden/integration/integration_tests_tests.cmake /home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/build/eden/eden/integration/integration_tests_tests.cmake cd /home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/build/eden/eden/integration && /usr/bin/cmake -D TEST_TARGET=integration_tests -D TEST_INTERPRETER=/usr/bin/python3.12 -D TEST_ENV=CMAKE_SOURCE_DIR=/home/alex/local/sapling -D TEST_EXECUTABLE=/home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/build/eden/eden/integration/integration_tests -D TEST_WORKING_DIR=/home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/build/eden -D TEST_LIST=integration_tests_TESTS -D TEST_PREFIX=integration_tests:: -D TEST_PROPERTIES= -D CTEST_FILE=/home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/build/eden/eden/integration/integration_tests_tests.cmake -P /home/alex/local/sapling/build/fbcode_builder/CMake/FBPythonTestAddTests.cmake Traceback (most recent call last): File "<frozen runpy>", line 198, in _run_module_as_main File "<frozen runpy>", line 88, in _run_code File "/home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/build/eden/eden/integration/integration_tests/__main__.py", line 197, in <module> File "/usr/lib64/python3.12/unittest/__init__.py", line 85, in __getattr__ raise AttributeError(f"module {__name__!r} has no attribute {name!r}") AttributeError: module 'unittest' has no attribute '_TextTestResult'. Did you mean: 'TextTestResult'? ``` After, works
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
mitrandir77
pushed a commit
to mitrandir77/velox
that referenced
this pull request
Nov 20, 2023
Summary: fix eden build with python 3.12 python 3.12 removes many long deprecated unittest features including _TextTestResult (deprecated in Python 3.2) notices as fedora 39 ships with python 3.12 X-link: facebook/sapling#778 Differential Revision: D51455615
facebook-github-bot
pushed a commit
to facebook/folly
that referenced
this pull request
Nov 20, 2023
Summary: X-link: facebookincubator/velox#7653 fix eden build with python 3.12 python 3.12 removes many long deprecated unittest features including _TextTestResult (deprecated in Python 3.2) notices as fedora 39 ships with python 3.12 X-link: facebook/sapling#778 Differential Revision: D51455615 fbshipit-source-id: f690f14b24b2645578113f769669179fba476657
facebook-github-bot
pushed a commit
to facebookexperimental/rust-shed
that referenced
this pull request
Nov 20, 2023
Summary: X-link: facebookincubator/velox#7653 fix eden build with python 3.12 python 3.12 removes many long deprecated unittest features including _TextTestResult (deprecated in Python 3.2) notices as fedora 39 ships with python 3.12 X-link: facebook/sapling#778 Differential Revision: D51455615 fbshipit-source-id: f690f14b24b2645578113f769669179fba476657
facebook-github-bot
pushed a commit
to facebook/hhvm
that referenced
this pull request
Nov 20, 2023
Summary: X-link: facebookincubator/velox#7653 fix eden build with python 3.12 python 3.12 removes many long deprecated unittest features including _TextTestResult (deprecated in Python 3.2) notices as fedora 39 ships with python 3.12 X-link: facebook/sapling#778 Differential Revision: D51455615 fbshipit-source-id: f690f14b24b2645578113f769669179fba476657
facebook-github-bot
pushed a commit
to facebook/fbthrift
that referenced
this pull request
Nov 20, 2023
Summary: X-link: facebookincubator/velox#7653 fix eden build with python 3.12 python 3.12 removes many long deprecated unittest features including _TextTestResult (deprecated in Python 3.2) notices as fedora 39 ships with python 3.12 X-link: facebook/sapling#778 Differential Revision: D51455615 fbshipit-source-id: f690f14b24b2645578113f769669179fba476657
facebook-github-bot
pushed a commit
to facebook/fb303
that referenced
this pull request
Nov 20, 2023
Summary: X-link: facebookincubator/velox#7653 fix eden build with python 3.12 python 3.12 removes many long deprecated unittest features including _TextTestResult (deprecated in Python 3.2) notices as fedora 39 ships with python 3.12 X-link: facebook/sapling#778 Differential Revision: D51455615 fbshipit-source-id: f690f14b24b2645578113f769669179fba476657
facebook-github-bot
pushed a commit
to facebook/mvfst
that referenced
this pull request
Nov 20, 2023
Summary: X-link: facebookincubator/velox#7653 fix eden build with python 3.12 python 3.12 removes many long deprecated unittest features including _TextTestResult (deprecated in Python 3.2) notices as fedora 39 ships with python 3.12 X-link: facebook/sapling#778 Differential Revision: D51455615 fbshipit-source-id: f690f14b24b2645578113f769669179fba476657
facebook-github-bot
pushed a commit
to facebook/proxygen
that referenced
this pull request
Nov 20, 2023
Summary: X-link: facebookincubator/velox#7653 fix eden build with python 3.12 python 3.12 removes many long deprecated unittest features including _TextTestResult (deprecated in Python 3.2) notices as fedora 39 ships with python 3.12 X-link: facebook/sapling#778 Differential Revision: D51455615 fbshipit-source-id: f690f14b24b2645578113f769669179fba476657
facebook-github-bot
pushed a commit
to facebookincubator/hsthrift
that referenced
this pull request
Nov 20, 2023
Summary: X-link: facebookincubator/velox#7653 fix eden build with python 3.12 python 3.12 removes many long deprecated unittest features including _TextTestResult (deprecated in Python 3.2) notices as fedora 39 ships with python 3.12 X-link: facebook/sapling#778 Differential Revision: D51455615 fbshipit-source-id: f690f14b24b2645578113f769669179fba476657
facebook-github-bot
pushed a commit
to facebook/wangle
that referenced
this pull request
Nov 20, 2023
Summary: X-link: facebookincubator/velox#7653 fix eden build with python 3.12 python 3.12 removes many long deprecated unittest features including _TextTestResult (deprecated in Python 3.2) notices as fedora 39 ships with python 3.12 X-link: facebook/sapling#778 Differential Revision: D51455615 fbshipit-source-id: f690f14b24b2645578113f769669179fba476657
This pull request has been merged in 35dceec. |
facebook-github-bot
pushed a commit
to facebook/watchman
that referenced
this pull request
Nov 20, 2023
Summary: X-link: facebookincubator/velox#7653 fix eden build with python 3.12 python 3.12 removes many long deprecated unittest features including _TextTestResult (deprecated in Python 3.2) notices as fedora 39 ships with python 3.12 X-link: facebook/sapling#778 Differential Revision: D51455615 fbshipit-source-id: f690f14b24b2645578113f769669179fba476657
facebook-github-bot
pushed a commit
to facebookincubator/fizz
that referenced
this pull request
Nov 20, 2023
Summary: X-link: facebookincubator/velox#7653 fix eden build with python 3.12 python 3.12 removes many long deprecated unittest features including _TextTestResult (deprecated in Python 3.2) notices as fedora 39 ships with python 3.12 X-link: facebook/sapling#778 Differential Revision: D51455615 fbshipit-source-id: f690f14b24b2645578113f769669179fba476657
facebook-github-bot
pushed a commit
to facebookincubator/velox
that referenced
this pull request
Nov 20, 2023
Summary: Pull Request resolved: #7653 fix eden build with python 3.12 python 3.12 removes many long deprecated unittest features including _TextTestResult (deprecated in Python 3.2) notices as fedora 39 ships with python 3.12 X-link: facebook/sapling#778 Test Plan: Local build with `./build/fbcode_builder/getdeps.py --allow-system-packages build --src-dir=. eden` Before: ``` FAILED: eden/integration/CMakeFiles/integration_tests.GEN_PY_EXE.util eden/integration/integration_tests_tests.cmake /home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/build/eden/eden/integration/integration_tests_tests.cmake cd /home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/build/eden/eden/integration && /usr/bin/cmake -D TEST_TARGET=integration_tests -D TEST_INTERPRETER=/usr/bin/python3.12 -D TEST_ENV=CMAKE_SOURCE_DIR=/home/alex/local/sapling -D TEST_EXECUTABLE=/home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/build/eden/eden/integration/integration_tests -D TEST_WORKING_DIR=/home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/build/eden -D TEST_LIST=integration_tests_TESTS -D TEST_PREFIX=integration_tests:: -D TEST_PROPERTIES= -D CTEST_FILE=/home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/build/eden/eden/integration/integration_tests_tests.cmake -P /home/alex/local/sapling/build/fbcode_builder/CMake/FBPythonTestAddTests.cmake Traceback (most recent call last): File "<frozen runpy>", line 198, in _run_module_as_main File "<frozen runpy>", line 88, in _run_code File "/home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/build/eden/eden/integration/integration_tests/__main__.py", line 197, in <module> File "/usr/lib64/python3.12/unittest/__init__.py", line 85, in __getattr__ raise AttributeError(f"module {__name__!r} has no attribute {name!r}") AttributeError: module 'unittest' has no attribute '_TextTestResult'. Did you mean: 'TextTestResult'? ``` After, works Differential Revision: D51455615 fbshipit-source-id: f690f14b24b2645578113f769669179fba476657
facebook-github-bot
pushed a commit
to facebookexperimental/edencommon
that referenced
this pull request
Nov 20, 2023
Summary: X-link: facebookincubator/velox#7653 fix eden build with python 3.12 python 3.12 removes many long deprecated unittest features including _TextTestResult (deprecated in Python 3.2) notices as fedora 39 ships with python 3.12 X-link: facebook/sapling#778 Differential Revision: D51455615 fbshipit-source-id: f690f14b24b2645578113f769669179fba476657
facebook-github-bot
pushed a commit
to facebook/fboss
that referenced
this pull request
Nov 20, 2023
Summary: X-link: facebookincubator/velox#7653 fix eden build with python 3.12 python 3.12 removes many long deprecated unittest features including _TextTestResult (deprecated in Python 3.2) notices as fedora 39 ships with python 3.12 X-link: facebook/sapling#778 Differential Revision: D51455615 fbshipit-source-id: f690f14b24b2645578113f769669179fba476657
Thanks @ahornby! |
facebook-github-bot
pushed a commit
to facebookincubator/katran
that referenced
this pull request
Nov 28, 2023
Summary: X-link: facebookincubator/velox#7653 fix eden build with python 3.12 python 3.12 removes many long deprecated unittest features including _TextTestResult (deprecated in Python 3.2) notices as fedora 39 ships with python 3.12 X-link: facebook/sapling#778 Differential Revision: D51455615 fbshipit-source-id: f690f14b24b2645578113f769669179fba476657
facebook-github-bot
pushed a commit
to facebook/openr
that referenced
this pull request
Jan 9, 2024
Summary: X-link: facebookincubator/velox#7653 fix eden build with python 3.12 python 3.12 removes many long deprecated unittest features including _TextTestResult (deprecated in Python 3.2) notices as fedora 39 ships with python 3.12 X-link: facebook/sapling#778 Differential Revision: D51455615 fbshipit-source-id: f690f14b24b2645578113f769669179fba476657
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix eden build with python 3.12
python 3.12 removes many long deprecated unittest features including _TextTestResult (deprecated in Python 3.2)
notices as fedora 39 ships with python 3.12
Test plan:
Local build with
./build/fbcode_builder/getdeps.py --allow-system-packages build --src-dir=. eden
Before:
After, works
Stack created with Sapling. Best reviewed with ReviewStack.