fix eden fs build with GCC 13.2.1 #748
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 15, 2023
|
@genevievehelsel has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
genevievehelsel
pushed a commit
to genevievehelsel/velox
that referenced
this pull request
Oct 16, 2023
Summary: fix eden fs build with GCC 13.2.1 Fixing two problems that broke builds on Fedora 38, which comes with GCC 13.2.1 * GCC 13.2.1 can't build the old rocksdb, so update the version * there was a missing include in BackingStoreType.h X-link: facebook/sapling#748 Reviewed By: sggutier Differential Revision: D50313436 Pulled By: genevievehelsel
genevievehelsel
pushed a commit
to genevievehelsel/velox
that referenced
this pull request
Oct 16, 2023
Summary: fix eden fs build with GCC 13.2.1 Fixing two problems that broke builds on Fedora 38, which comes with GCC 13.2.1 * GCC 13.2.1 can't build the old rocksdb, so update the version * there was a missing include in BackingStoreType.h X-link: facebook/sapling#748 Test Plan: build locally with: ``` ./build/fbcode_builder/getdeps.py --allow-system-packages build --src-dir=. --project-install-prefix eden:/usr/local eden ``` Before, eden fs build breaks at rocksdb on uint8_t ``` FAILED: CMakeFiles/rocksdb.dir/table/block_based/data_block_hash_index.cc.o /usr/bin/c++ -DLZ4 -DOS_LINUX -DROCKSDB_FALLOCATE_PRESENT -DROCKSDB_LIB_IO_POSIX -DROCKSDB_MALLOC_USABLE_SIZE -DROCKSDB_NO_DYNAMIC_EXTENSION -DROCKSDB_PLATFORM_POSIX -DROCKSDB_PTHREAD_ADAPTIVE_MUTEX -DROCKSDB_RANGESYNC_PRESENT -DROCKSDB_SCHED_GETCPU_PRESENT -DSNAPPY -I/home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/extracted/rocksdb-v7.7.3.tar.gz/rocksdb-7.7.3 -I/home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/extracted/rocksdb-v7.7.3.tar.gz/rocksdb-7.7.3/include -isystem /home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/extracted/rocksdb-v7.7.3.tar.gz/rocksdb-7.7.3/third-party/gtest-1.8.1/fused-src -W -Wextra -Wall -pthread -Wsign-compare -Wshadow -Wno-unused-parameter -Wno-unused-variable -Woverloaded-virtual -Wnon-virtual-dtor -Wno-missing-field-initializers -Wno-strict-aliasing -Wno-invalid-offsetof -fno-omit-frame-pointer -momit-leaf-frame-pointer -fno-builtin-memcmp -O2 -g -DNDEBUG -std=gnu++17 -MD -MT CMakeFiles/rocksdb.dir/table/block_based/data_block_hash_index.cc.o -MF CMakeFiles/rocksdb.dir/table/block_based/data_block_hash_index.cc.o.d -o CMakeFiles/rocksdb.dir/table/block_based/data_block_hash_index.cc.o -c /home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/extracted/rocksdb-v7.7.3.tar.gz/rocksdb-7.7.3/table/block_based/data_block_hash_index.cc In file included from /home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/extracted/rocksdb-v7.7.3.tar.gz/rocksdb-7.7.3/table/block_based/data_block_hash_index.cc:9: /home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/extracted/rocksdb-v7.7.3.tar.gz/rocksdb-7.7.3/table/block_based/data_block_hash_index.h:65:7: error: ‘uint8_t’ does not name a type 65 | const uint8_t kNoEntry = 255; | ^~~~~~~ /home/alex/local/tmp/fridge/fbc ``` After, works --- Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/sapling/pull/748). * facebook/sapling#750 * facebook/sapling#749 * __->__ facebook/sapling#748 Reviewed By: sggutier Differential Revision: D50313436 Pulled By: genevievehelsel
genevievehelsel
pushed a commit
to genevievehelsel/velox
that referenced
this pull request
Oct 16, 2023
Summary: fix eden fs build with GCC 13.2.1 Fixing two problems that broke builds on Fedora 38, which comes with GCC 13.2.1 * GCC 13.2.1 can't build the old rocksdb, so update the version * there was a missing include in BackingStoreType.h X-link: facebook/sapling#748 Test Plan: build locally with: ``` ./build/fbcode_builder/getdeps.py --allow-system-packages build --src-dir=. --project-install-prefix eden:/usr/local eden ``` Before, eden fs build breaks at rocksdb on uint8_t ``` FAILED: CMakeFiles/rocksdb.dir/table/block_based/data_block_hash_index.cc.o /usr/bin/c++ -DLZ4 -DOS_LINUX -DROCKSDB_FALLOCATE_PRESENT -DROCKSDB_LIB_IO_POSIX -DROCKSDB_MALLOC_USABLE_SIZE -DROCKSDB_NO_DYNAMIC_EXTENSION -DROCKSDB_PLATFORM_POSIX -DROCKSDB_PTHREAD_ADAPTIVE_MUTEX -DROCKSDB_RANGESYNC_PRESENT -DROCKSDB_SCHED_GETCPU_PRESENT -DSNAPPY -I/home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/extracted/rocksdb-v7.7.3.tar.gz/rocksdb-7.7.3 -I/home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/extracted/rocksdb-v7.7.3.tar.gz/rocksdb-7.7.3/include -isystem /home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/extracted/rocksdb-v7.7.3.tar.gz/rocksdb-7.7.3/third-party/gtest-1.8.1/fused-src -W -Wextra -Wall -pthread -Wsign-compare -Wshadow -Wno-unused-parameter -Wno-unused-variable -Woverloaded-virtual -Wnon-virtual-dtor -Wno-missing-field-initializers -Wno-strict-aliasing -Wno-invalid-offsetof -fno-omit-frame-pointer -momit-leaf-frame-pointer -fno-builtin-memcmp -O2 -g -DNDEBUG -std=gnu++17 -MD -MT CMakeFiles/rocksdb.dir/table/block_based/data_block_hash_index.cc.o -MF CMakeFiles/rocksdb.dir/table/block_based/data_block_hash_index.cc.o.d -o CMakeFiles/rocksdb.dir/table/block_based/data_block_hash_index.cc.o -c /home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/extracted/rocksdb-v7.7.3.tar.gz/rocksdb-7.7.3/table/block_based/data_block_hash_index.cc In file included from /home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/extracted/rocksdb-v7.7.3.tar.gz/rocksdb-7.7.3/table/block_based/data_block_hash_index.cc:9: /home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/extracted/rocksdb-v7.7.3.tar.gz/rocksdb-7.7.3/table/block_based/data_block_hash_index.h:65:7: error: ‘uint8_t’ does not name a type 65 | const uint8_t kNoEntry = 255; | ^~~~~~~ /home/alex/local/tmp/fridge/fbc ``` After, works --- Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/sapling/pull/748). * facebook/sapling#750 * facebook/sapling#749 * __->__ facebook/sapling#748 Reviewed By: sggutier Differential Revision: D50313436 Pulled By: genevievehelsel
genevievehelsel
pushed a commit
to genevievehelsel/velox
that referenced
this pull request
Oct 16, 2023
…ebookincubator#7071) Summary: Pull Request resolved: facebookincubator#7071 fix CI warning about node12 by updating actions/checkout version Update the actions/checkout version to fix build warning X-link: facebook/sapling#749 Test Plan: regenerate actions with: ``` ./build/fbcode_builder/getdeps.py --allow-system-packages generate-github-actions --no-tests --free-up-disk --os-type=linux --src-dir=. --output-dir=.github/workflows --job-name "EdenFS " --job-file-prefix=edenfs_ eden ``` Before, CI has warning: ```The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2``` After, warning is gone --- Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/sapling/pull/749). * facebook/sapling#750 * __->__ facebook/sapling#749 * facebook/sapling#748 Reviewed By: sggutier Differential Revision: D50313430 Pulled By: genevievehelsel fbshipit-source-id: 87d73fd056d03e11e78000fe6ab763bd9206be1e
genevievehelsel
pushed a commit
to genevievehelsel/velox
that referenced
this pull request
Oct 16, 2023
…ebookincubator#7071) Summary: fix CI warning about node12 by updating actions/checkout version Update the actions/checkout version to fix build warning X-link: facebook/sapling#749 Test Plan: regenerate actions with: ``` ./build/fbcode_builder/getdeps.py --allow-system-packages generate-github-actions --no-tests --free-up-disk --os-type=linux --src-dir=. --output-dir=.github/workflows --job-name "EdenFS " --job-file-prefix=edenfs_ eden ``` Before, CI has warning: ```The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2``` After, warning is gone --- Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/sapling/pull/749). * facebook/sapling#750 * __->__ facebook/sapling#749 * facebook/sapling#748 Reviewed By: sggutier Differential Revision: D50313430 Pulled By: genevievehelsel
genevievehelsel
pushed a commit
to genevievehelsel/velox
that referenced
this pull request
Oct 16, 2023
Summary: Pull Request resolved: facebookincubator#7072 use system patchelf in eden fs build Saves us from doing a fetch and build of autoconf, libtool, automake and patchelf during the arfifacts part of CI X-link: facebook/sapling#750 Test Plan: run locally with: `/build/fbcode_builder/getdeps.py --allow-system-packages fixup-dyn-deps --allow-system-packages --strip --src-dir=. eden _artifacts/linux --project-install-prefix eden:/usr/local --final-install-prefix /usr/local` Before, builds autoconf, automake, libtool, patchelf from source After, uses the system installed version regenerate actions with:`./build/fbcode_builder/getdeps.py --allow-system-packages generate-github-actions --no-tests --free-up-disk --os-type=linux --src-dir=. --output-dir=.github/workflows --job-name "EdenFS " --job-file-prefix=edenfs_ eden` --- Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/sapling/pull/750). * __->__ facebook/sapling#750 * facebook/sapling#749 * facebook/sapling#748 Reviewed By: sggutier Differential Revision: D50313417 Pulled By: genevievehelsel fbshipit-source-id: 8cadaabed8805fa31346e467585242cf4a6cf8af
|
This doesn't build on Windows - rocksdb specifically I haven't dug too deep just yet, but CI reports the error as I've got no immediate suggestions just yet to fix this, but I'll try to find time this week to take a look and giving more actionable feedback |
genevievehelsel
pushed a commit
to genevievehelsel/velox
that referenced
this pull request
Oct 16, 2023
Summary: fix eden fs build with GCC 13.2.1 Fixing two problems that broke builds on Fedora 38, which comes with GCC 13.2.1 * GCC 13.2.1 can't build the old rocksdb, so update the version * there was a missing include in BackingStoreType.h X-link: facebook/sapling#748 Test Plan: build locally with: ``` ./build/fbcode_builder/getdeps.py --allow-system-packages build --src-dir=. --project-install-prefix eden:/usr/local eden ``` Before, eden fs build breaks at rocksdb on uint8_t ``` FAILED: CMakeFiles/rocksdb.dir/table/block_based/data_block_hash_index.cc.o /usr/bin/c++ -DLZ4 -DOS_LINUX -DROCKSDB_FALLOCATE_PRESENT -DROCKSDB_LIB_IO_POSIX -DROCKSDB_MALLOC_USABLE_SIZE -DROCKSDB_NO_DYNAMIC_EXTENSION -DROCKSDB_PLATFORM_POSIX -DROCKSDB_PTHREAD_ADAPTIVE_MUTEX -DROCKSDB_RANGESYNC_PRESENT -DROCKSDB_SCHED_GETCPU_PRESENT -DSNAPPY -I/home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/extracted/rocksdb-v7.7.3.tar.gz/rocksdb-7.7.3 -I/home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/extracted/rocksdb-v7.7.3.tar.gz/rocksdb-7.7.3/include -isystem /home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/extracted/rocksdb-v7.7.3.tar.gz/rocksdb-7.7.3/third-party/gtest-1.8.1/fused-src -W -Wextra -Wall -pthread -Wsign-compare -Wshadow -Wno-unused-parameter -Wno-unused-variable -Woverloaded-virtual -Wnon-virtual-dtor -Wno-missing-field-initializers -Wno-strict-aliasing -Wno-invalid-offsetof -fno-omit-frame-pointer -momit-leaf-frame-pointer -fno-builtin-memcmp -O2 -g -DNDEBUG -std=gnu++17 -MD -MT CMakeFiles/rocksdb.dir/table/block_based/data_block_hash_index.cc.o -MF CMakeFiles/rocksdb.dir/table/block_based/data_block_hash_index.cc.o.d -o CMakeFiles/rocksdb.dir/table/block_based/data_block_hash_index.cc.o -c /home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/extracted/rocksdb-v7.7.3.tar.gz/rocksdb-7.7.3/table/block_based/data_block_hash_index.cc In file included from /home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/extracted/rocksdb-v7.7.3.tar.gz/rocksdb-7.7.3/table/block_based/data_block_hash_index.cc:9: /home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/extracted/rocksdb-v7.7.3.tar.gz/rocksdb-7.7.3/table/block_based/data_block_hash_index.h:65:7: error: ‘uint8_t’ does not name a type 65 | const uint8_t kNoEntry = 255; | ^~~~~~~ /home/alex/local/tmp/fridge/fbc ``` After, works --- Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/sapling/pull/748). * facebook/sapling#750 * facebook/sapling#749 * __->__ facebook/sapling#748 Reviewed By: sggutier Differential Revision: D50313436 Pulled By: genevievehelsel
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 16, 2023
Summary: X-link: facebookincubator/velox#7071 fix CI warning about node12 by updating actions/checkout version Update the actions/checkout version to fix build warning Pull Request resolved: #749 Test Plan: regenerate actions with: ``` ./build/fbcode_builder/getdeps.py --allow-system-packages generate-github-actions --no-tests --free-up-disk --os-type=linux --src-dir=. --output-dir=.github/workflows --job-name "EdenFS " --job-file-prefix=edenfs_ eden ``` Before, CI has warning: ```The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2``` After, warning is gone --- Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/sapling/pull/749). * #750 * __->__ #749 * #748 Reviewed By: sggutier Differential Revision: D50313430 Pulled By: genevievehelsel fbshipit-source-id: 4d55d36f7509be51bb4e26728ddbce8e45faba40
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 16, 2023
Summary: X-link: facebookincubator/velox#7072 use system patchelf in eden fs build Saves us from doing a fetch and build of autoconf, libtool, automake and patchelf during the arfifacts part of CI Pull Request resolved: #750 Test Plan: run locally with: `/build/fbcode_builder/getdeps.py --allow-system-packages fixup-dyn-deps --allow-system-packages --strip --src-dir=. eden _artifacts/linux --project-install-prefix eden:/usr/local --final-install-prefix /usr/local` Before, builds autoconf, automake, libtool, patchelf from source After, uses the system installed version regenerate actions with:`./build/fbcode_builder/getdeps.py --allow-system-packages generate-github-actions --no-tests --free-up-disk --os-type=linux --src-dir=. --output-dir=.github/workflows --job-name "EdenFS " --job-file-prefix=edenfs_ eden` --- Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/sapling/pull/750). * __->__ #750 * #749 * #748 Reviewed By: sggutier Differential Revision: D50313417 Pulled By: genevievehelsel fbshipit-source-id: 7c585357c848c15a65c5797d6c8750d1119b6efd
facebook-github-bot
pushed a commit
to facebookincubator/velox
that referenced
this pull request
Oct 16, 2023
Summary: Pull Request resolved: #7071 fix CI warning about node12 by updating actions/checkout version Update the actions/checkout version to fix build warning X-link: facebook/sapling#749 Test Plan: regenerate actions with: ``` ./build/fbcode_builder/getdeps.py --allow-system-packages generate-github-actions --no-tests --free-up-disk --os-type=linux --src-dir=. --output-dir=.github/workflows --job-name "EdenFS " --job-file-prefix=edenfs_ eden ``` Before, CI has warning: ```The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2``` After, warning is gone --- Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/sapling/pull/749). * facebook/sapling#750 * __->__ facebook/sapling#749 * facebook/sapling#748 Reviewed By: sggutier Differential Revision: D50313430 Pulled By: genevievehelsel fbshipit-source-id: 4d55d36f7509be51bb4e26728ddbce8e45faba40
facebook-github-bot
pushed a commit
to facebookincubator/velox
that referenced
this pull request
Oct 16, 2023
Summary: Pull Request resolved: #7072 use system patchelf in eden fs build Saves us from doing a fetch and build of autoconf, libtool, automake and patchelf during the arfifacts part of CI X-link: facebook/sapling#750 Test Plan: run locally with: `/build/fbcode_builder/getdeps.py --allow-system-packages fixup-dyn-deps --allow-system-packages --strip --src-dir=. eden _artifacts/linux --project-install-prefix eden:/usr/local --final-install-prefix /usr/local` Before, builds autoconf, automake, libtool, patchelf from source After, uses the system installed version regenerate actions with:`./build/fbcode_builder/getdeps.py --allow-system-packages generate-github-actions --no-tests --free-up-disk --os-type=linux --src-dir=. --output-dir=.github/workflows --job-name "EdenFS " --job-file-prefix=edenfs_ eden` --- Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/sapling/pull/750). * __->__ facebook/sapling#750 * facebook/sapling#749 * facebook/sapling#748 Reviewed By: sggutier Differential Revision: D50313417 Pulled By: genevievehelsel fbshipit-source-id: 7c585357c848c15a65c5797d6c8750d1119b6efd
I can probably take a look later in the week. My first guess would be that updating from windows-2019 to windows-2022 runner might make a difference as it updates to vs build tools 2022 |
|
I reproduced the windows MSVC '_rdtsc' error with visual studio build tools 2019 and 2022. Looks like others had similar issue in rocksdb, and raised potential fix in facebook/rocksdb#11794 or facebook/rocksdb#11766 |
|
facebook/rocksdb#12008 for the windows build issue :) |
|
@ahornby has updated the pull request. You must reimport the pull request before landing. |
|
@mitrandir77 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Fixing two problems that broke builds on Fedora 38, which comes with GCC 13.2.1
* GCC 13.2.1 can't build the old rocksdb, so update the version
* there was a missing include in BackingStoreType.h
Test plan:
build locally with:
```
./build/fbcode_builder/getdeps.py --allow-system-packages build --src-dir=. --project-install-prefix eden:/usr/local eden
```
Before, eden fs build breaks at rocksdb on uint8_t
```
FAILED: CMakeFiles/rocksdb.dir/table/block_based/data_block_hash_index.cc.o
/usr/bin/c++ -DLZ4 -DOS_LINUX -DROCKSDB_FALLOCATE_PRESENT -DROCKSDB_LIB_IO_POSIX -DROCKSDB_MALLOC_USABLE_SIZE -DROCKSDB_NO_DYNAMIC_EXTENSION -DROCKSDB_PLATFORM_POSIX -DROCKSDB_PTHREAD_ADAPTIVE_MUTEX -DROCKSDB_RANGESYNC_PRESENT -DROCKSDB_SCHED_GETCPU_PRESENT -DSNAPPY -I/home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/extracted/rocksdb-v7.7.3.tar.gz/rocksdb-7.7.3 -I/home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/extracted/rocksdb-v7.7.3.tar.gz/rocksdb-7.7.3/include -isystem /home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/extracted/rocksdb-v7.7.3.tar.gz/rocksdb-7.7.3/third-party/gtest-1.8.1/fused-src -W -Wextra -Wall -pthread -Wsign-compare -Wshadow -Wno-unused-parameter -Wno-unused-variable -Woverloaded-virtual -Wnon-virtual-dtor -Wno-missing-field-initializers -Wno-strict-aliasing -Wno-invalid-offsetof -fno-omit-frame-pointer -momit-leaf-frame-pointer -fno-builtin-memcmp -O2 -g -DNDEBUG -std=gnu++17 -MD -MT CMakeFiles/rocksdb.dir/table/block_based/data_block_hash_index.cc.o -MF CMakeFiles/rocksdb.dir/table/block_based/data_block_hash_index.cc.o.d -o CMakeFiles/rocksdb.dir/table/block_based/data_block_hash_index.cc.o -c /home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/extracted/rocksdb-v7.7.3.tar.gz/rocksdb-7.7.3/table/block_based/data_block_hash_index.cc
In file included from /home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/extracted/rocksdb-v7.7.3.tar.gz/rocksdb-7.7.3/table/block_based/data_block_hash_index.cc:9:
/home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/extracted/rocksdb-v7.7.3.tar.gz/rocksdb-7.7.3/table/block_based/data_block_hash_index.h:65:7: error: ‘uint8_t’ does not name a type
65 | const uint8_t kNoEntry = 255;
| ^~~~~~~
/home/alex/local/tmp/fridge/fbc
```
After, works
|
@ahornby has updated the pull request. You must reimport the pull request before landing. |
|
@genevievehelsel has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
1 similar comment
|
@genevievehelsel has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
genevievehelsel
pushed a commit
to genevievehelsel/velox
that referenced
this pull request
Nov 21, 2023
Summary: fix eden fs build with GCC 13.2.1 Fixing two problems that broke builds on Fedora 38, which comes with GCC 13.2.1 * GCC 13.2.1 can't build the old rocksdb, so update the version * there was a missing include in BackingStoreType.h X-link: facebook/sapling#748 Reviewed By: mitrandir77 Differential Revision: D50313436 Pulled By: genevievehelsel
genevievehelsel
pushed a commit
to genevievehelsel/velox
that referenced
this pull request
Nov 22, 2023
Summary: fix eden fs build with GCC 13.2.1 Fixing two problems that broke builds on Fedora 38, which comes with GCC 13.2.1 * GCC 13.2.1 can't build the old rocksdb, so update the version * there was a missing include in BackingStoreType.h X-link: facebook/sapling#748 Test Plan: build locally with: ``` ./build/fbcode_builder/getdeps.py --allow-system-packages build --src-dir=. --project-install-prefix eden:/usr/local eden ``` Before, eden fs build breaks at rocksdb on uint8_t ``` FAILED: CMakeFiles/rocksdb.dir/table/block_based/data_block_hash_index.cc.o /usr/bin/c++ -DLZ4 -DOS_LINUX -DROCKSDB_FALLOCATE_PRESENT -DROCKSDB_LIB_IO_POSIX -DROCKSDB_MALLOC_USABLE_SIZE -DROCKSDB_NO_DYNAMIC_EXTENSION -DROCKSDB_PLATFORM_POSIX -DROCKSDB_PTHREAD_ADAPTIVE_MUTEX -DROCKSDB_RANGESYNC_PRESENT -DROCKSDB_SCHED_GETCPU_PRESENT -DSNAPPY -I/home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/extracted/rocksdb-v7.7.3.tar.gz/rocksdb-7.7.3 -I/home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/extracted/rocksdb-v7.7.3.tar.gz/rocksdb-7.7.3/include -isystem /home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/extracted/rocksdb-v7.7.3.tar.gz/rocksdb-7.7.3/third-party/gtest-1.8.1/fused-src -W -Wextra -Wall -pthread -Wsign-compare -Wshadow -Wno-unused-parameter -Wno-unused-variable -Woverloaded-virtual -Wnon-virtual-dtor -Wno-missing-field-initializers -Wno-strict-aliasing -Wno-invalid-offsetof -fno-omit-frame-pointer -momit-leaf-frame-pointer -fno-builtin-memcmp -O2 -g -DNDEBUG -std=gnu++17 -MD -MT CMakeFiles/rocksdb.dir/table/block_based/data_block_hash_index.cc.o -MF CMakeFiles/rocksdb.dir/table/block_based/data_block_hash_index.cc.o.d -o CMakeFiles/rocksdb.dir/table/block_based/data_block_hash_index.cc.o -c /home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/extracted/rocksdb-v7.7.3.tar.gz/rocksdb-7.7.3/table/block_based/data_block_hash_index.cc In file included from /home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/extracted/rocksdb-v7.7.3.tar.gz/rocksdb-7.7.3/table/block_based/data_block_hash_index.cc:9: /home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/extracted/rocksdb-v7.7.3.tar.gz/rocksdb-7.7.3/table/block_based/data_block_hash_index.h:65:7: error: ‘uint8_t’ does not name a type 65 | const uint8_t kNoEntry = 255; | ^~~~~~~ /home/alex/local/tmp/fridge/fbc ``` After, works Reviewed By: mitrandir77 Differential Revision: D50313436 Pulled By: genevievehelsel
facebook-github-bot
pushed a commit
to facebook/folly
that referenced
this pull request
Nov 22, 2023
Summary: X-link: facebookincubator/velox#7070 fix eden fs build with GCC 13.2.1 Fixing two problems that broke builds on Fedora 38, which comes with GCC 13.2.1 * GCC 13.2.1 can't build the old rocksdb, so update the version * there was a missing include in BackingStoreType.h X-link: facebook/sapling#748 Reviewed By: mitrandir77 Differential Revision: D50313436 Pulled By: genevievehelsel fbshipit-source-id: 970227f29641768c8314aa0537654470d097d7bf
facebook-github-bot
pushed a commit
to facebookincubator/hsthrift
that referenced
this pull request
Nov 22, 2023
Summary: X-link: facebookincubator/velox#7070 fix eden fs build with GCC 13.2.1 Fixing two problems that broke builds on Fedora 38, which comes with GCC 13.2.1 * GCC 13.2.1 can't build the old rocksdb, so update the version * there was a missing include in BackingStoreType.h X-link: facebook/sapling#748 Reviewed By: mitrandir77 Differential Revision: D50313436 Pulled By: genevievehelsel fbshipit-source-id: 970227f29641768c8314aa0537654470d097d7bf
facebook-github-bot
pushed a commit
to facebook/mvfst
that referenced
this pull request
Nov 22, 2023
Summary: X-link: facebookincubator/velox#7070 fix eden fs build with GCC 13.2.1 Fixing two problems that broke builds on Fedora 38, which comes with GCC 13.2.1 * GCC 13.2.1 can't build the old rocksdb, so update the version * there was a missing include in BackingStoreType.h X-link: facebook/sapling#748 Reviewed By: mitrandir77 Differential Revision: D50313436 Pulled By: genevievehelsel fbshipit-source-id: 970227f29641768c8314aa0537654470d097d7bf
facebook-github-bot
pushed a commit
to facebook/proxygen
that referenced
this pull request
Nov 22, 2023
Summary: X-link: facebookincubator/velox#7070 fix eden fs build with GCC 13.2.1 Fixing two problems that broke builds on Fedora 38, which comes with GCC 13.2.1 * GCC 13.2.1 can't build the old rocksdb, so update the version * there was a missing include in BackingStoreType.h X-link: facebook/sapling#748 Reviewed By: mitrandir77 Differential Revision: D50313436 Pulled By: genevievehelsel fbshipit-source-id: 970227f29641768c8314aa0537654470d097d7bf
facebook-github-bot
pushed a commit
to facebookexperimental/rust-shed
that referenced
this pull request
Nov 22, 2023
Summary: X-link: facebookincubator/velox#7070 fix eden fs build with GCC 13.2.1 Fixing two problems that broke builds on Fedora 38, which comes with GCC 13.2.1 * GCC 13.2.1 can't build the old rocksdb, so update the version * there was a missing include in BackingStoreType.h X-link: facebook/sapling#748 Reviewed By: mitrandir77 Differential Revision: D50313436 Pulled By: genevievehelsel fbshipit-source-id: 970227f29641768c8314aa0537654470d097d7bf
facebook-github-bot
pushed a commit
to facebook/hhvm
that referenced
this pull request
Nov 22, 2023
Summary: X-link: facebookincubator/velox#7070 fix eden fs build with GCC 13.2.1 Fixing two problems that broke builds on Fedora 38, which comes with GCC 13.2.1 * GCC 13.2.1 can't build the old rocksdb, so update the version * there was a missing include in BackingStoreType.h X-link: facebook/sapling#748 Reviewed By: mitrandir77 Differential Revision: D50313436 Pulled By: genevievehelsel fbshipit-source-id: 970227f29641768c8314aa0537654470d097d7bf
facebook-github-bot
pushed a commit
to facebookincubator/fizz
that referenced
this pull request
Nov 22, 2023
Summary: X-link: facebookincubator/velox#7070 fix eden fs build with GCC 13.2.1 Fixing two problems that broke builds on Fedora 38, which comes with GCC 13.2.1 * GCC 13.2.1 can't build the old rocksdb, so update the version * there was a missing include in BackingStoreType.h X-link: facebook/sapling#748 Reviewed By: mitrandir77 Differential Revision: D50313436 Pulled By: genevievehelsel fbshipit-source-id: 970227f29641768c8314aa0537654470d097d7bf
facebook-github-bot
pushed a commit
to facebook/wangle
that referenced
this pull request
Nov 22, 2023
Summary: X-link: facebookincubator/velox#7070 fix eden fs build with GCC 13.2.1 Fixing two problems that broke builds on Fedora 38, which comes with GCC 13.2.1 * GCC 13.2.1 can't build the old rocksdb, so update the version * there was a missing include in BackingStoreType.h X-link: facebook/sapling#748 Reviewed By: mitrandir77 Differential Revision: D50313436 Pulled By: genevievehelsel fbshipit-source-id: 970227f29641768c8314aa0537654470d097d7bf
facebook-github-bot
pushed a commit
to facebook/fboss
that referenced
this pull request
Nov 22, 2023
Summary: X-link: facebookincubator/velox#7070 fix eden fs build with GCC 13.2.1 Fixing two problems that broke builds on Fedora 38, which comes with GCC 13.2.1 * GCC 13.2.1 can't build the old rocksdb, so update the version * there was a missing include in BackingStoreType.h X-link: facebook/sapling#748 Reviewed By: mitrandir77 Differential Revision: D50313436 Pulled By: genevievehelsel fbshipit-source-id: 970227f29641768c8314aa0537654470d097d7bf
facebook-github-bot
pushed a commit
to facebook/fb303
that referenced
this pull request
Nov 22, 2023
Summary: X-link: facebookincubator/velox#7070 fix eden fs build with GCC 13.2.1 Fixing two problems that broke builds on Fedora 38, which comes with GCC 13.2.1 * GCC 13.2.1 can't build the old rocksdb, so update the version * there was a missing include in BackingStoreType.h X-link: facebook/sapling#748 Reviewed By: mitrandir77 Differential Revision: D50313436 Pulled By: genevievehelsel fbshipit-source-id: 970227f29641768c8314aa0537654470d097d7bf
facebook-github-bot
pushed a commit
to facebookexperimental/edencommon
that referenced
this pull request
Nov 22, 2023
Summary: X-link: facebookincubator/velox#7070 fix eden fs build with GCC 13.2.1 Fixing two problems that broke builds on Fedora 38, which comes with GCC 13.2.1 * GCC 13.2.1 can't build the old rocksdb, so update the version * there was a missing include in BackingStoreType.h X-link: facebook/sapling#748 Reviewed By: mitrandir77 Differential Revision: D50313436 Pulled By: genevievehelsel fbshipit-source-id: 970227f29641768c8314aa0537654470d097d7bf
facebook-github-bot
pushed a commit
to facebook/fbthrift
that referenced
this pull request
Nov 22, 2023
Summary: X-link: facebookincubator/velox#7070 fix eden fs build with GCC 13.2.1 Fixing two problems that broke builds on Fedora 38, which comes with GCC 13.2.1 * GCC 13.2.1 can't build the old rocksdb, so update the version * there was a missing include in BackingStoreType.h X-link: facebook/sapling#748 Reviewed By: mitrandir77 Differential Revision: D50313436 Pulled By: genevievehelsel fbshipit-source-id: 970227f29641768c8314aa0537654470d097d7bf
|
@genevievehelsel merged this pull request in 4ae736d. |
facebook-github-bot
pushed a commit
to facebookincubator/velox
that referenced
this pull request
Nov 22, 2023
Summary: Pull Request resolved: #7070 fix eden fs build with GCC 13.2.1 Fixing two problems that broke builds on Fedora 38, which comes with GCC 13.2.1 * GCC 13.2.1 can't build the old rocksdb, so update the version * there was a missing include in BackingStoreType.h X-link: facebook/sapling#748 Test Plan: build locally with: ``` ./build/fbcode_builder/getdeps.py --allow-system-packages build --src-dir=. --project-install-prefix eden:/usr/local eden ``` Before, eden fs build breaks at rocksdb on uint8_t ``` FAILED: CMakeFiles/rocksdb.dir/table/block_based/data_block_hash_index.cc.o /usr/bin/c++ -DLZ4 -DOS_LINUX -DROCKSDB_FALLOCATE_PRESENT -DROCKSDB_LIB_IO_POSIX -DROCKSDB_MALLOC_USABLE_SIZE -DROCKSDB_NO_DYNAMIC_EXTENSION -DROCKSDB_PLATFORM_POSIX -DROCKSDB_PTHREAD_ADAPTIVE_MUTEX -DROCKSDB_RANGESYNC_PRESENT -DROCKSDB_SCHED_GETCPU_PRESENT -DSNAPPY -I/home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/extracted/rocksdb-v7.7.3.tar.gz/rocksdb-7.7.3 -I/home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/extracted/rocksdb-v7.7.3.tar.gz/rocksdb-7.7.3/include -isystem /home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/extracted/rocksdb-v7.7.3.tar.gz/rocksdb-7.7.3/third-party/gtest-1.8.1/fused-src -W -Wextra -Wall -pthread -Wsign-compare -Wshadow -Wno-unused-parameter -Wno-unused-variable -Woverloaded-virtual -Wnon-virtual-dtor -Wno-missing-field-initializers -Wno-strict-aliasing -Wno-invalid-offsetof -fno-omit-frame-pointer -momit-leaf-frame-pointer -fno-builtin-memcmp -O2 -g -DNDEBUG -std=gnu++17 -MD -MT CMakeFiles/rocksdb.dir/table/block_based/data_block_hash_index.cc.o -MF CMakeFiles/rocksdb.dir/table/block_based/data_block_hash_index.cc.o.d -o CMakeFiles/rocksdb.dir/table/block_based/data_block_hash_index.cc.o -c /home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/extracted/rocksdb-v7.7.3.tar.gz/rocksdb-7.7.3/table/block_based/data_block_hash_index.cc In file included from /home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/extracted/rocksdb-v7.7.3.tar.gz/rocksdb-7.7.3/table/block_based/data_block_hash_index.cc:9: /home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/extracted/rocksdb-v7.7.3.tar.gz/rocksdb-7.7.3/table/block_based/data_block_hash_index.h:65:7: error: ‘uint8_t’ does not name a type 65 | const uint8_t kNoEntry = 255; | ^~~~~~~ /home/alex/local/tmp/fridge/fbc ``` After, works Reviewed By: mitrandir77 Differential Revision: D50313436 Pulled By: genevievehelsel fbshipit-source-id: 970227f29641768c8314aa0537654470d097d7bf
facebook-github-bot
pushed a commit
to facebook/watchman
that referenced
this pull request
Nov 22, 2023
Summary: X-link: facebookincubator/velox#7070 fix eden fs build with GCC 13.2.1 Fixing two problems that broke builds on Fedora 38, which comes with GCC 13.2.1 * GCC 13.2.1 can't build the old rocksdb, so update the version * there was a missing include in BackingStoreType.h X-link: facebook/sapling#748 Reviewed By: mitrandir77 Differential Revision: D50313436 Pulled By: genevievehelsel fbshipit-source-id: 970227f29641768c8314aa0537654470d097d7bf
facebook-github-bot
pushed a commit
to facebookincubator/katran
that referenced
this pull request
Nov 28, 2023
Summary: X-link: facebookincubator/velox#7070 fix eden fs build with GCC 13.2.1 Fixing two problems that broke builds on Fedora 38, which comes with GCC 13.2.1 * GCC 13.2.1 can't build the old rocksdb, so update the version * there was a missing include in BackingStoreType.h X-link: facebook/sapling#748 Reviewed By: mitrandir77 Differential Revision: D50313436 Pulled By: genevievehelsel fbshipit-source-id: 970227f29641768c8314aa0537654470d097d7bf
facebook-github-bot
pushed a commit
to facebook/openr
that referenced
this pull request
Jan 9, 2024
Summary: X-link: facebookincubator/velox#7070 fix eden fs build with GCC 13.2.1 Fixing two problems that broke builds on Fedora 38, which comes with GCC 13.2.1 * GCC 13.2.1 can't build the old rocksdb, so update the version * there was a missing include in BackingStoreType.h X-link: facebook/sapling#748 Reviewed By: mitrandir77 Differential Revision: D50313436 Pulled By: genevievehelsel fbshipit-source-id: 970227f29641768c8314aa0537654470d097d7bf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix eden fs build with GCC 13.2.1
Fixing two problems that broke builds on Fedora 38, which comes with GCC 13.2.1
Test plan:
build locally with:
Before, eden fs build breaks at rocksdb on uint8_t
After, works