Skip to content
This repository has been archived by the owner on Feb 12, 2022. It is now read-only.

Turn crash in JSON.stringify into introspection error #2412

Closed

Conversation

sb98052
Copy link

@sb98052 sb98052 commented Aug 9, 2018

Release notes: None

Fixes #2411

@sb98052 sb98052 force-pushed the json-stringify-on-abstract branch from 0ae0800 to b7ee959 Compare August 9, 2018 22:11
Copy link
Contributor

@hermanventer hermanventer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We really should get around to providing builtins like this with appropriate source context so that they can provide decent compiler diagnostics.

Copy link

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sb98052 is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants