Skip to content
This repository has been archived by the owner on Feb 12, 2022. It is now read-only.

Turn crash in JSON.stringify into introspection error #2412

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/intrinsics/ecma262/JSON.js
Original file line number Diff line number Diff line change
Expand Up @@ -478,8 +478,16 @@ export default function(realm: Realm): ObjectValue {
// 9. Let wrapper be ObjectCreate(%ObjectPrototype%).
let wrapper = Create.ObjectCreate(realm, realm.intrinsics.ObjectPrototype);

let isAbstract = value instanceof AbstractValue;

// #2411
if (isAbstract && value.values.isTop()) {
AbstractValue.reportIntrospectionError(value);
throw new FatalError();
}

// TODO #1012: Make result abstract if any nested element is an abstract value.
if (value instanceof AbstractValue || (value instanceof ObjectValue && value.isPartialObject())) {
if (isAbstract || (value instanceof ObjectValue && value.isPartialObject())) {
// Return abstract result. This enables cloning via JSON.parse(JSON.stringify(...)).
let clonedValue = InternalJSONClone(realm, value);
let result = AbstractValue.createTemporalFromTemplate(realm, JSONStringify, StringValue, [clonedValue], {
Expand Down
9 changes: 9 additions & 0 deletions test/serializer/abstract/JSONStringifyOnAbstract2411.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
// throws introspection error
//
(function() {
let o = __abstract("object", "(o)");
let s;
s = "A" + JSON.stringify(o);

global.s = s;
})();