docs: CRAN 3.11.0 #1001
Merged
docs: CRAN 3.11.0 #1001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ameter to overwrite default calculation
- negative trend is not interpretable for MMM - force negative coef when trend is negative to get positive decomp
…dstock feat: instead of Inf, use channel_constr_up, which by default is 10 for target_efficiency
The refactoring of initBounds & listOutputPrev in refresh_hyps was wrong in 774c18d
* build(deps): bump braces from 3.0.2 to 3.0.3 in /website (#997) * fix: refresh hyps check + use data available in json + refresh hyps + upper constraints fix when higher than mean (#974) * fix: refresh hyps check #960 + use data available in json * fix: update based on gz's comments * fix: fixed penalties and other fixed hyps on refreshing models * fix: refresh plot when chain is broken + feat: new bounds_freedom parameter to overwrite default calculation * fix: import and store original model when not in original plot_dir * recode: applied styler::tidyverse_style() to clean code for CRAN * fix: paid_media_total calc * fix: print ExportedModel only when available * fix: deal with negative trend - negative trend is not interpretable for MMM - force negative coef when trend is negative to get positive decomp * fix: upper constraint issue on BA for target_efficiency and weibull adstock feat: instead of Inf, use channel_constr_up, which by default is 10 for target_efficiency * fix: reverse wrong bounds update in refresh_hyps The refactoring of initBounds & listOutputPrev in refresh_hyps was wrong in 774c18d * recode: apply styler::tidyverse_style() --------- Co-authored-by: gufengzhou <[email protected]> --------- Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: gufengzhou <[email protected]>
facebook-github-bot
added
the
CLA Signed
|
v3.11.0 landed to CRAN after matching their requirements: https://cran.r-project.org/web/packages/Robyn/index.html |
laresbernardo
commented
Jun 26, 2024
| p2 <- suppressWarnings( | ||
| ggplot(plotWaterfallLoop, aes(x = .data$id, fill = .data$sign)) + | ||
| geom_rect(aes( | ||
| x = .data$rn, xmin = .data$id - 0.45, xmax = .data$id + 0.45, |
There was a problem hiding this comment.
@gufengzhou this x was removed and I think it's the issue reported in FB. We should re-include it and get rid of the warning. Maybe use this rn instead of id in ggplot main x aes.
https://www.facebook.com/share/p/tX9wjmbNPwTMd8MX/?mibextid=K35XfP
There was a problem hiding this comment.
Sure please fix it. Just make sure the order of the names are right (desc by decomp percentage)
There was a problem hiding this comment.
I submitted the fix to CRAN to see if we can update it as 3.11.1. We had to get rid of the suppressWarnings() there #1011
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.