-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: CRAN 3.11.0 #1001
Merged
Merged
docs: CRAN 3.11.0 #1001
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
5ef8c50
fix: refresh hyps check #960 + use data available in json
laresbernardo ba2a318
fix: update based on gz's comments
laresbernardo 6699559
Merge branch 'main' into bl02
laresbernardo 774c18d
fix: fixed penalties and other fixed hyps on refreshing models
laresbernardo 5895a5e
fix: refresh plot when chain is broken + feat: new bounds_freedom par…
laresbernardo 3d94c85
fix: import and store original model when not in original plot_dir
laresbernardo fb21795
recode: applied styler::tidyverse_style() to clean code for CRAN
laresbernardo a061843
fix: paid_media_total calc
laresbernardo 3401c1a
fix: print ExportedModel only when available
laresbernardo 57d14db
fix: deal with negative trend
gufengzhou d649356
fix: upper constraint issue on BA for target_efficiency and weibull a…
laresbernardo 3221bc1
fix: reverse wrong bounds update in refresh_hyps
gufengzhou 6e865a7
recode: apply styler::tidyverse_style()
laresbernardo 8ef5edc
docs: fix hyper_names() items for CRAN
laresbernardo ad3f2eb
docs: Preparing CRAN version (#1000)
laresbernardo 48ccac3
docs: v3.11.0 submit
laresbernardo 05d40db
Merge branch 'main' into cran_3.11.0
laresbernardo dfbeb30
fix: maintainer email
laresbernardo 9c780ce
docs: no need to suggest shiny
laresbernardo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,14 +1,14 @@ | ||
Package: Robyn | ||
Type: Package | ||
Title: Semi-Automated Marketing Mix Modeling (MMM) from Meta Marketing Science | ||
Version: 3.10.7.9001 | ||
Version: 3.11.0 | ||
Authors@R: c( | ||
person("Gufeng", "Zhou", , "[email protected]", c("cre","aut")), | ||
person("Bernardo", "Lares", , "[email protected]", c("aut")), | ||
person("Gufeng", "Zhou", , "[email protected]", c("aut")), | ||
person("Bernardo", "Lares", , "[email protected]", c("cre","aut")), | ||
person("Leonel", "Sentana", , "[email protected]", c("aut")), | ||
person("Igor", "Skokan", , "[email protected]", c("aut")), | ||
person("Meta Platforms, Inc.", role = c("cph", "fnd"))) | ||
Maintainer: Gufeng Zhou <gufeng@meta.com> | ||
Maintainer: Bernardo Lares <laresbernardo@gmail.com> | ||
Description: Semi-Automated Marketing Mix Modeling (MMM) aiming to reduce human bias by means of ridge regression and evolutionary algorithms, enables actionable decision making providing a budget allocation and diminishing returns curves and allows ground-truth calibration to account for causation. | ||
Depends: | ||
R (>= 4.0.0) | ||
|
@@ -30,8 +30,6 @@ Imports: | |
reticulate, | ||
stringr, | ||
tidyr | ||
Suggests: | ||
shiny | ||
Config/reticulate: | ||
list( | ||
packages = list( | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -33,10 +33,3 @@ Meta's Robyn is MIT licensed, as found in the LICENSE file. | |
|
||
- Terms of Use - https://opensource.facebook.com/legal/terms | ||
- Privacy Policy - https://opensource.facebook.com/legal/privacy | ||
|
||
## Contact | ||
|
||
* [email protected], Gufeng Zhou, Marketing Science Partner | ||
* [email protected], Leonel Sentana, Marketing Science Partner | ||
* [email protected], Igor Skokan, Marketing Science Partner | ||
* [email protected], Bernardo Lares, Marketing Science Partner |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gufengzhou this x was removed and I think it's the issue reported in FB. We should re-include it and get rid of the warning. Maybe use this rn instead of id in ggplot main x aes.
https://www.facebook.com/share/p/tX9wjmbNPwTMd8MX/?mibextid=K35XfP
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure please fix it. Just make sure the order of the names are right (desc by decomp percentage)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I submitted the fix to CRAN to see if we can update it as 3.11.1. We had to get rid of the
suppressWarnings()
there #1011