fix eden fs build with GCC 13.2.1 #7070
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for meta-velox canceled.
|
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D50313436 |
genevievehelsel
pushed a commit
to genevievehelsel/velox
that referenced
this pull request
Oct 16, 2023
Summary: fix eden fs build with GCC 13.2.1 Fixing two problems that broke builds on Fedora 38, which comes with GCC 13.2.1 * GCC 13.2.1 can't build the old rocksdb, so update the version * there was a missing include in BackingStoreType.h X-link: facebook/sapling#748 Test Plan: build locally with: ``` ./build/fbcode_builder/getdeps.py --allow-system-packages build --src-dir=. --project-install-prefix eden:/usr/local eden ``` Before, eden fs build breaks at rocksdb on uint8_t ``` FAILED: CMakeFiles/rocksdb.dir/table/block_based/data_block_hash_index.cc.o /usr/bin/c++ -DLZ4 -DOS_LINUX -DROCKSDB_FALLOCATE_PRESENT -DROCKSDB_LIB_IO_POSIX -DROCKSDB_MALLOC_USABLE_SIZE -DROCKSDB_NO_DYNAMIC_EXTENSION -DROCKSDB_PLATFORM_POSIX -DROCKSDB_PTHREAD_ADAPTIVE_MUTEX -DROCKSDB_RANGESYNC_PRESENT -DROCKSDB_SCHED_GETCPU_PRESENT -DSNAPPY -I/home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/extracted/rocksdb-v7.7.3.tar.gz/rocksdb-7.7.3 -I/home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/extracted/rocksdb-v7.7.3.tar.gz/rocksdb-7.7.3/include -isystem /home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/extracted/rocksdb-v7.7.3.tar.gz/rocksdb-7.7.3/third-party/gtest-1.8.1/fused-src -W -Wextra -Wall -pthread -Wsign-compare -Wshadow -Wno-unused-parameter -Wno-unused-variable -Woverloaded-virtual -Wnon-virtual-dtor -Wno-missing-field-initializers -Wno-strict-aliasing -Wno-invalid-offsetof -fno-omit-frame-pointer -momit-leaf-frame-pointer -fno-builtin-memcmp -O2 -g -DNDEBUG -std=gnu++17 -MD -MT CMakeFiles/rocksdb.dir/table/block_based/data_block_hash_index.cc.o -MF CMakeFiles/rocksdb.dir/table/block_based/data_block_hash_index.cc.o.d -o CMakeFiles/rocksdb.dir/table/block_based/data_block_hash_index.cc.o -c /home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/extracted/rocksdb-v7.7.3.tar.gz/rocksdb-7.7.3/table/block_based/data_block_hash_index.cc In file included from /home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/extracted/rocksdb-v7.7.3.tar.gz/rocksdb-7.7.3/table/block_based/data_block_hash_index.cc:9: /home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/extracted/rocksdb-v7.7.3.tar.gz/rocksdb-7.7.3/table/block_based/data_block_hash_index.h:65:7: error: ‘uint8_t’ does not name a type 65 | const uint8_t kNoEntry = 255; | ^~~~~~~ /home/alex/local/tmp/fridge/fbc ``` After, works --- Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/sapling/pull/748). * facebook/sapling#750 * facebook/sapling#749 * __->__ facebook/sapling#748 Reviewed By: sggutier Differential Revision: D50313436 Pulled By: genevievehelsel
genevievehelsel
force-pushed
the
export-D50313436
branch
from
fecca6b to
6a7a585
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50313436 |
genevievehelsel
pushed a commit
to genevievehelsel/velox
that referenced
this pull request
Oct 16, 2023
Summary: fix eden fs build with GCC 13.2.1 Fixing two problems that broke builds on Fedora 38, which comes with GCC 13.2.1 * GCC 13.2.1 can't build the old rocksdb, so update the version * there was a missing include in BackingStoreType.h X-link: facebook/sapling#748 Test Plan: build locally with: ``` ./build/fbcode_builder/getdeps.py --allow-system-packages build --src-dir=. --project-install-prefix eden:/usr/local eden ``` Before, eden fs build breaks at rocksdb on uint8_t ``` FAILED: CMakeFiles/rocksdb.dir/table/block_based/data_block_hash_index.cc.o /usr/bin/c++ -DLZ4 -DOS_LINUX -DROCKSDB_FALLOCATE_PRESENT -DROCKSDB_LIB_IO_POSIX -DROCKSDB_MALLOC_USABLE_SIZE -DROCKSDB_NO_DYNAMIC_EXTENSION -DROCKSDB_PLATFORM_POSIX -DROCKSDB_PTHREAD_ADAPTIVE_MUTEX -DROCKSDB_RANGESYNC_PRESENT -DROCKSDB_SCHED_GETCPU_PRESENT -DSNAPPY -I/home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/extracted/rocksdb-v7.7.3.tar.gz/rocksdb-7.7.3 -I/home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/extracted/rocksdb-v7.7.3.tar.gz/rocksdb-7.7.3/include -isystem /home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/extracted/rocksdb-v7.7.3.tar.gz/rocksdb-7.7.3/third-party/gtest-1.8.1/fused-src -W -Wextra -Wall -pthread -Wsign-compare -Wshadow -Wno-unused-parameter -Wno-unused-variable -Woverloaded-virtual -Wnon-virtual-dtor -Wno-missing-field-initializers -Wno-strict-aliasing -Wno-invalid-offsetof -fno-omit-frame-pointer -momit-leaf-frame-pointer -fno-builtin-memcmp -O2 -g -DNDEBUG -std=gnu++17 -MD -MT CMakeFiles/rocksdb.dir/table/block_based/data_block_hash_index.cc.o -MF CMakeFiles/rocksdb.dir/table/block_based/data_block_hash_index.cc.o.d -o CMakeFiles/rocksdb.dir/table/block_based/data_block_hash_index.cc.o -c /home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/extracted/rocksdb-v7.7.3.tar.gz/rocksdb-7.7.3/table/block_based/data_block_hash_index.cc In file included from /home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/extracted/rocksdb-v7.7.3.tar.gz/rocksdb-7.7.3/table/block_based/data_block_hash_index.cc:9: /home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/extracted/rocksdb-v7.7.3.tar.gz/rocksdb-7.7.3/table/block_based/data_block_hash_index.h:65:7: error: ‘uint8_t’ does not name a type 65 | const uint8_t kNoEntry = 255; | ^~~~~~~ /home/alex/local/tmp/fridge/fbc ``` After, works --- Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/sapling/pull/748). * facebook/sapling#750 * facebook/sapling#749 * __->__ facebook/sapling#748 Reviewed By: sggutier Differential Revision: D50313436 Pulled By: genevievehelsel
genevievehelsel
force-pushed
the
export-D50313436
branch
from
6a7a585 to
a7090c0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50313436 |
genevievehelsel
pushed a commit
to genevievehelsel/velox
that referenced
this pull request
Oct 16, 2023
Summary: fix eden fs build with GCC 13.2.1 Fixing two problems that broke builds on Fedora 38, which comes with GCC 13.2.1 * GCC 13.2.1 can't build the old rocksdb, so update the version * there was a missing include in BackingStoreType.h X-link: facebook/sapling#748 Test Plan: build locally with: ``` ./build/fbcode_builder/getdeps.py --allow-system-packages build --src-dir=. --project-install-prefix eden:/usr/local eden ``` Before, eden fs build breaks at rocksdb on uint8_t ``` FAILED: CMakeFiles/rocksdb.dir/table/block_based/data_block_hash_index.cc.o /usr/bin/c++ -DLZ4 -DOS_LINUX -DROCKSDB_FALLOCATE_PRESENT -DROCKSDB_LIB_IO_POSIX -DROCKSDB_MALLOC_USABLE_SIZE -DROCKSDB_NO_DYNAMIC_EXTENSION -DROCKSDB_PLATFORM_POSIX -DROCKSDB_PTHREAD_ADAPTIVE_MUTEX -DROCKSDB_RANGESYNC_PRESENT -DROCKSDB_SCHED_GETCPU_PRESENT -DSNAPPY -I/home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/extracted/rocksdb-v7.7.3.tar.gz/rocksdb-7.7.3 -I/home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/extracted/rocksdb-v7.7.3.tar.gz/rocksdb-7.7.3/include -isystem /home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/extracted/rocksdb-v7.7.3.tar.gz/rocksdb-7.7.3/third-party/gtest-1.8.1/fused-src -W -Wextra -Wall -pthread -Wsign-compare -Wshadow -Wno-unused-parameter -Wno-unused-variable -Woverloaded-virtual -Wnon-virtual-dtor -Wno-missing-field-initializers -Wno-strict-aliasing -Wno-invalid-offsetof -fno-omit-frame-pointer -momit-leaf-frame-pointer -fno-builtin-memcmp -O2 -g -DNDEBUG -std=gnu++17 -MD -MT CMakeFiles/rocksdb.dir/table/block_based/data_block_hash_index.cc.o -MF CMakeFiles/rocksdb.dir/table/block_based/data_block_hash_index.cc.o.d -o CMakeFiles/rocksdb.dir/table/block_based/data_block_hash_index.cc.o -c /home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/extracted/rocksdb-v7.7.3.tar.gz/rocksdb-7.7.3/table/block_based/data_block_hash_index.cc In file included from /home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/extracted/rocksdb-v7.7.3.tar.gz/rocksdb-7.7.3/table/block_based/data_block_hash_index.cc:9: /home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/extracted/rocksdb-v7.7.3.tar.gz/rocksdb-7.7.3/table/block_based/data_block_hash_index.h:65:7: error: ‘uint8_t’ does not name a type 65 | const uint8_t kNoEntry = 255; | ^~~~~~~ /home/alex/local/tmp/fridge/fbc ``` After, works --- Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/sapling/pull/748). * facebook/sapling#750 * facebook/sapling#749 * __->__ facebook/sapling#748 Reviewed By: sggutier Differential Revision: D50313436 Pulled By: genevievehelsel
genevievehelsel
force-pushed
the
export-D50313436
branch
from
a7090c0 to
309395d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50313436 |
genevievehelsel
force-pushed
the
export-D50313436
branch
from
309395d to
460f23f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50313436 |
Summary: fix eden fs build with GCC 13.2.1 Fixing two problems that broke builds on Fedora 38, which comes with GCC 13.2.1 * GCC 13.2.1 can't build the old rocksdb, so update the version * there was a missing include in BackingStoreType.h X-link: facebook/sapling#748 Test Plan: build locally with: ``` ./build/fbcode_builder/getdeps.py --allow-system-packages build --src-dir=. --project-install-prefix eden:/usr/local eden ``` Before, eden fs build breaks at rocksdb on uint8_t ``` FAILED: CMakeFiles/rocksdb.dir/table/block_based/data_block_hash_index.cc.o /usr/bin/c++ -DLZ4 -DOS_LINUX -DROCKSDB_FALLOCATE_PRESENT -DROCKSDB_LIB_IO_POSIX -DROCKSDB_MALLOC_USABLE_SIZE -DROCKSDB_NO_DYNAMIC_EXTENSION -DROCKSDB_PLATFORM_POSIX -DROCKSDB_PTHREAD_ADAPTIVE_MUTEX -DROCKSDB_RANGESYNC_PRESENT -DROCKSDB_SCHED_GETCPU_PRESENT -DSNAPPY -I/home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/extracted/rocksdb-v7.7.3.tar.gz/rocksdb-7.7.3 -I/home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/extracted/rocksdb-v7.7.3.tar.gz/rocksdb-7.7.3/include -isystem /home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/extracted/rocksdb-v7.7.3.tar.gz/rocksdb-7.7.3/third-party/gtest-1.8.1/fused-src -W -Wextra -Wall -pthread -Wsign-compare -Wshadow -Wno-unused-parameter -Wno-unused-variable -Woverloaded-virtual -Wnon-virtual-dtor -Wno-missing-field-initializers -Wno-strict-aliasing -Wno-invalid-offsetof -fno-omit-frame-pointer -momit-leaf-frame-pointer -fno-builtin-memcmp -O2 -g -DNDEBUG -std=gnu++17 -MD -MT CMakeFiles/rocksdb.dir/table/block_based/data_block_hash_index.cc.o -MF CMakeFiles/rocksdb.dir/table/block_based/data_block_hash_index.cc.o.d -o CMakeFiles/rocksdb.dir/table/block_based/data_block_hash_index.cc.o -c /home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/extracted/rocksdb-v7.7.3.tar.gz/rocksdb-7.7.3/table/block_based/data_block_hash_index.cc In file included from /home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/extracted/rocksdb-v7.7.3.tar.gz/rocksdb-7.7.3/table/block_based/data_block_hash_index.cc:9: /home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/extracted/rocksdb-v7.7.3.tar.gz/rocksdb-7.7.3/table/block_based/data_block_hash_index.h:65:7: error: ‘uint8_t’ does not name a type 65 | const uint8_t kNoEntry = 255; | ^~~~~~~ /home/alex/local/tmp/fridge/fbc ``` After, works Reviewed By: mitrandir77 Differential Revision: D50313436 Pulled By: genevievehelsel
genevievehelsel
force-pushed
the
export-D50313436
branch
from
460f23f to
66163b6
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50313436 |
facebook-github-bot
pushed a commit
to facebook/folly
that referenced
this pull request
Nov 22, 2023
Summary: X-link: facebookincubator/velox#7070 fix eden fs build with GCC 13.2.1 Fixing two problems that broke builds on Fedora 38, which comes with GCC 13.2.1 * GCC 13.2.1 can't build the old rocksdb, so update the version * there was a missing include in BackingStoreType.h X-link: facebook/sapling#748 Reviewed By: mitrandir77 Differential Revision: D50313436 Pulled By: genevievehelsel fbshipit-source-id: 970227f29641768c8314aa0537654470d097d7bf
facebook-github-bot
pushed a commit
to facebookincubator/hsthrift
that referenced
this pull request
Nov 22, 2023
Summary: X-link: facebookincubator/velox#7070 fix eden fs build with GCC 13.2.1 Fixing two problems that broke builds on Fedora 38, which comes with GCC 13.2.1 * GCC 13.2.1 can't build the old rocksdb, so update the version * there was a missing include in BackingStoreType.h X-link: facebook/sapling#748 Reviewed By: mitrandir77 Differential Revision: D50313436 Pulled By: genevievehelsel fbshipit-source-id: 970227f29641768c8314aa0537654470d097d7bf
facebook-github-bot
pushed a commit
to facebook/mvfst
that referenced
this pull request
Nov 22, 2023
Summary: X-link: facebookincubator/velox#7070 fix eden fs build with GCC 13.2.1 Fixing two problems that broke builds on Fedora 38, which comes with GCC 13.2.1 * GCC 13.2.1 can't build the old rocksdb, so update the version * there was a missing include in BackingStoreType.h X-link: facebook/sapling#748 Reviewed By: mitrandir77 Differential Revision: D50313436 Pulled By: genevievehelsel fbshipit-source-id: 970227f29641768c8314aa0537654470d097d7bf
facebook-github-bot
pushed a commit
to facebook/proxygen
that referenced
this pull request
Nov 22, 2023
Summary: X-link: facebookincubator/velox#7070 fix eden fs build with GCC 13.2.1 Fixing two problems that broke builds on Fedora 38, which comes with GCC 13.2.1 * GCC 13.2.1 can't build the old rocksdb, so update the version * there was a missing include in BackingStoreType.h X-link: facebook/sapling#748 Reviewed By: mitrandir77 Differential Revision: D50313436 Pulled By: genevievehelsel fbshipit-source-id: 970227f29641768c8314aa0537654470d097d7bf
facebook-github-bot
pushed a commit
to facebookexperimental/rust-shed
that referenced
this pull request
Nov 22, 2023
Summary: X-link: facebookincubator/velox#7070 fix eden fs build with GCC 13.2.1 Fixing two problems that broke builds on Fedora 38, which comes with GCC 13.2.1 * GCC 13.2.1 can't build the old rocksdb, so update the version * there was a missing include in BackingStoreType.h X-link: facebook/sapling#748 Reviewed By: mitrandir77 Differential Revision: D50313436 Pulled By: genevievehelsel fbshipit-source-id: 970227f29641768c8314aa0537654470d097d7bf
facebook-github-bot
pushed a commit
to facebook/hhvm
that referenced
this pull request
Nov 22, 2023
Summary: X-link: facebookincubator/velox#7070 fix eden fs build with GCC 13.2.1 Fixing two problems that broke builds on Fedora 38, which comes with GCC 13.2.1 * GCC 13.2.1 can't build the old rocksdb, so update the version * there was a missing include in BackingStoreType.h X-link: facebook/sapling#748 Reviewed By: mitrandir77 Differential Revision: D50313436 Pulled By: genevievehelsel fbshipit-source-id: 970227f29641768c8314aa0537654470d097d7bf
facebook-github-bot
pushed a commit
to facebookincubator/fizz
that referenced
this pull request
Nov 22, 2023
Summary: X-link: facebookincubator/velox#7070 fix eden fs build with GCC 13.2.1 Fixing two problems that broke builds on Fedora 38, which comes with GCC 13.2.1 * GCC 13.2.1 can't build the old rocksdb, so update the version * there was a missing include in BackingStoreType.h X-link: facebook/sapling#748 Reviewed By: mitrandir77 Differential Revision: D50313436 Pulled By: genevievehelsel fbshipit-source-id: 970227f29641768c8314aa0537654470d097d7bf
facebook-github-bot
pushed a commit
to facebook/wangle
that referenced
this pull request
Nov 22, 2023
Summary: X-link: facebookincubator/velox#7070 fix eden fs build with GCC 13.2.1 Fixing two problems that broke builds on Fedora 38, which comes with GCC 13.2.1 * GCC 13.2.1 can't build the old rocksdb, so update the version * there was a missing include in BackingStoreType.h X-link: facebook/sapling#748 Reviewed By: mitrandir77 Differential Revision: D50313436 Pulled By: genevievehelsel fbshipit-source-id: 970227f29641768c8314aa0537654470d097d7bf
facebook-github-bot
pushed a commit
to facebook/fboss
that referenced
this pull request
Nov 22, 2023
Summary: X-link: facebookincubator/velox#7070 fix eden fs build with GCC 13.2.1 Fixing two problems that broke builds on Fedora 38, which comes with GCC 13.2.1 * GCC 13.2.1 can't build the old rocksdb, so update the version * there was a missing include in BackingStoreType.h X-link: facebook/sapling#748 Reviewed By: mitrandir77 Differential Revision: D50313436 Pulled By: genevievehelsel fbshipit-source-id: 970227f29641768c8314aa0537654470d097d7bf
facebook-github-bot
pushed a commit
to facebook/sapling
that referenced
this pull request
Nov 22, 2023
Summary: X-link: facebookincubator/velox#7070 fix eden fs build with GCC 13.2.1 Fixing two problems that broke builds on Fedora 38, which comes with GCC 13.2.1 * GCC 13.2.1 can't build the old rocksdb, so update the version * there was a missing include in BackingStoreType.h Pull Request resolved: #748 Test Plan: build locally with: ``` ./build/fbcode_builder/getdeps.py --allow-system-packages build --src-dir=. --project-install-prefix eden:/usr/local eden ``` Before, eden fs build breaks at rocksdb on uint8_t ``` FAILED: CMakeFiles/rocksdb.dir/table/block_based/data_block_hash_index.cc.o /usr/bin/c++ -DLZ4 -DOS_LINUX -DROCKSDB_FALLOCATE_PRESENT -DROCKSDB_LIB_IO_POSIX -DROCKSDB_MALLOC_USABLE_SIZE -DROCKSDB_NO_DYNAMIC_EXTENSION -DROCKSDB_PLATFORM_POSIX -DROCKSDB_PTHREAD_ADAPTIVE_MUTEX -DROCKSDB_RANGESYNC_PRESENT -DROCKSDB_SCHED_GETCPU_PRESENT -DSNAPPY -I/home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/extracted/rocksdb-v7.7.3.tar.gz/rocksdb-7.7.3 -I/home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/extracted/rocksdb-v7.7.3.tar.gz/rocksdb-7.7.3/include -isystem /home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/extracted/rocksdb-v7.7.3.tar.gz/rocksdb-7.7.3/third-party/gtest-1.8.1/fused-src -W -Wextra -Wall -pthread -Wsign-compare -Wshadow -Wno-unused-parameter -Wno-unused-variable -Woverloaded-virtual -Wnon-virtual-dtor -Wno-missing-field-initializers -Wno-strict-aliasing -Wno-invalid-offsetof -fno-omit-frame-pointer -momit-leaf-frame-pointer -fno-builtin-memcmp -O2 -g -DNDEBUG -std=gnu++17 -MD -MT CMakeFiles/rocksdb.dir/table/block_based/data_block_hash_index.cc.o -MF CMakeFiles/rocksdb.dir/table/block_based/data_block_hash_index.cc.o.d -o CMakeFiles/rocksdb.dir/table/block_based/data_block_hash_index.cc.o -c /home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/extracted/rocksdb-v7.7.3.tar.gz/rocksdb-7.7.3/table/block_based/data_block_hash_index.cc In file included from /home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/extracted/rocksdb-v7.7.3.tar.gz/rocksdb-7.7.3/table/block_based/data_block_hash_index.cc:9: /home/alex/local/tmp/fridge/fbcode_builder_getdeps-ZhomeZalexZlocalZsaplingZbuildZfbcode_builder/extracted/rocksdb-v7.7.3.tar.gz/rocksdb-7.7.3/table/block_based/data_block_hash_index.h:65:7: error: ‘uint8_t’ does not name a type 65 | const uint8_t kNoEntry = 255; | ^~~~~~~ /home/alex/local/tmp/fridge/fbc ``` After, works Reviewed By: mitrandir77 Differential Revision: D50313436 Pulled By: genevievehelsel fbshipit-source-id: 970227f29641768c8314aa0537654470d097d7bf
facebook-github-bot
pushed a commit
to facebook/fb303
that referenced
this pull request
Nov 22, 2023
Summary: X-link: facebookincubator/velox#7070 fix eden fs build with GCC 13.2.1 Fixing two problems that broke builds on Fedora 38, which comes with GCC 13.2.1 * GCC 13.2.1 can't build the old rocksdb, so update the version * there was a missing include in BackingStoreType.h X-link: facebook/sapling#748 Reviewed By: mitrandir77 Differential Revision: D50313436 Pulled By: genevievehelsel fbshipit-source-id: 970227f29641768c8314aa0537654470d097d7bf
facebook-github-bot
pushed a commit
to facebookexperimental/edencommon
that referenced
this pull request
Nov 22, 2023
Summary: X-link: facebookincubator/velox#7070 fix eden fs build with GCC 13.2.1 Fixing two problems that broke builds on Fedora 38, which comes with GCC 13.2.1 * GCC 13.2.1 can't build the old rocksdb, so update the version * there was a missing include in BackingStoreType.h X-link: facebook/sapling#748 Reviewed By: mitrandir77 Differential Revision: D50313436 Pulled By: genevievehelsel fbshipit-source-id: 970227f29641768c8314aa0537654470d097d7bf
facebook-github-bot
pushed a commit
to facebook/fbthrift
that referenced
this pull request
Nov 22, 2023
Summary: X-link: facebookincubator/velox#7070 fix eden fs build with GCC 13.2.1 Fixing two problems that broke builds on Fedora 38, which comes with GCC 13.2.1 * GCC 13.2.1 can't build the old rocksdb, so update the version * there was a missing include in BackingStoreType.h X-link: facebook/sapling#748 Reviewed By: mitrandir77 Differential Revision: D50313436 Pulled By: genevievehelsel fbshipit-source-id: 970227f29641768c8314aa0537654470d097d7bf
facebook-github-bot
pushed a commit
to facebook/watchman
that referenced
this pull request
Nov 22, 2023
Summary: X-link: facebookincubator/velox#7070 fix eden fs build with GCC 13.2.1 Fixing two problems that broke builds on Fedora 38, which comes with GCC 13.2.1 * GCC 13.2.1 can't build the old rocksdb, so update the version * there was a missing include in BackingStoreType.h X-link: facebook/sapling#748 Reviewed By: mitrandir77 Differential Revision: D50313436 Pulled By: genevievehelsel fbshipit-source-id: 970227f29641768c8314aa0537654470d097d7bf
|
@genevievehelsel merged this pull request in 0d019f9. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
facebook-github-bot
pushed a commit
to facebookincubator/katran
that referenced
this pull request
Nov 28, 2023
Summary: X-link: facebookincubator/velox#7070 fix eden fs build with GCC 13.2.1 Fixing two problems that broke builds on Fedora 38, which comes with GCC 13.2.1 * GCC 13.2.1 can't build the old rocksdb, so update the version * there was a missing include in BackingStoreType.h X-link: facebook/sapling#748 Reviewed By: mitrandir77 Differential Revision: D50313436 Pulled By: genevievehelsel fbshipit-source-id: 970227f29641768c8314aa0537654470d097d7bf
facebook-github-bot
pushed a commit
to facebook/openr
that referenced
this pull request
Jan 9, 2024
Summary: X-link: facebookincubator/velox#7070 fix eden fs build with GCC 13.2.1 Fixing two problems that broke builds on Fedora 38, which comes with GCC 13.2.1 * GCC 13.2.1 can't build the old rocksdb, so update the version * there was a missing include in BackingStoreType.h X-link: facebook/sapling#748 Reviewed By: mitrandir77 Differential Revision: D50313436 Pulled By: genevievehelsel fbshipit-source-id: 970227f29641768c8314aa0537654470d097d7bf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
fix eden fs build with GCC 13.2.1
Fixing two problems that broke builds on Fedora 38, which comes with GCC 13.2.1
X-link: facebook/sapling#748
Reviewed By: sggutier
Differential Revision: D50313436
Pulled By: genevievehelsel