Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two and tree #1

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Conversation

repsdorph
Copy link

Now works with py2 and py3.

There still are some ugly code, eg mapping where i do a "if PY2:" do to some unicode-problems.

for line in f:
if any(map(lambda c: 128 < ord(c) < 160, line)):
line = line.encode("iso8859-1").decode("windows-1252")
line = line

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

dukebody referenced this pull request in lead-ratings/gender-guesser Nov 25, 2015
Convert the data file to utf-8 to avoid expensive entity replacement.
@dukebody
Copy link

dukebody commented Dec 6, 2015

Hi, I've released a fork of this package at https://pypi.python.org/pypi/gender-guesser/ which already supports Python 3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants