Features for reverse calls, notifs, custom-params #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magik6k
force-pushed
the
feat/reverese-calling
branch
4 times, most recently
from
53e73de to
5abb7ba
Compare
magik6k
force-pushed
the
feat/reverese-calling
branch
from
5abb7ba to
72c92bf
Compare
|
This is related to filecoin-project/lotus#9863 (comment) |
|
Reviewer note - reviewing commit-by-commit may be easiest, I tried to put each feature into it's own commit. |
7 tasks
magik6k
force-pushed
the
feat/reverese-calling
branch
from
72c92bf to
da92324
Compare
This was referenced Jan 16, 2023
magik6k
force-pushed
the
feat/reverese-calling
branch
from
da92324 to
81b43de
Compare
magik6k
force-pushed
the
feat/reverese-calling
branch
from
81b43de to
36330f4
Compare
geoff-vball
reviewed
Jan 25, 2023
Comment on lines
+460
to
+462
| // hasCtx is 1 if the function has a context.Context as its first argument. | ||
| // Used as the number of the first non-context argument. | ||
| hasCtx int |
There was a problem hiding this comment.
Thanks for commenting this. Very confusing.
geoff-vball
approved these changes
Jan 25, 2023
| var t T | ||
| err := json.Unmarshal(p, &t) | ||
|
|
||
| // todo also handle list-encoding automagically (json.Unmarshal doesn't do that, does it?) |
There was a problem hiding this comment.
Nope, it's a nice to have, but not needed afaict. The spec doesn't say that endpoints need to support both, so it's up to the endpoint really.
This was referenced Feb 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All of the above is needed to make it possible to implement / consume
eth_subscribecorrectly with this library.See rpc_test.go for usage examples.