Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(find): find only consideres lack of OK's when finding gaps #774

Closed
wants to merge 1 commit into from
Closed

fix(find): find only consideres lack of OK's when finding gaps #774

wants to merge 1 commit into from
+53 −20

Conversation

frrist
Copy link
Member

@frrist frrist commented Nov 23, 2021

#769 address this bug, but is slightly larger in scope. We can take this as is or incorporate into #769

@frrist frrist self-assigned this Nov 23, 2021
@frrist frrist requested review from iand and placer14 November 23, 2021 16:42
@placer14 placer14 mentioned this pull request Nov 24, 2021
Closed
@placer14
Copy link
Contributor

placer14 commented Nov 24, 2021 •
edited
Loading

Superseded by #778 which fixes the behavior in refactoring. New unit test is included. Closing.

@placer14 placer14 closed this Nov 24, 2021
@placer14 placer14 deleted the frrist/fix-773 branch November 24, 2021 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@placer14 placer14 placer14 left review comments

@iand iand Awaiting requested review from iand

Assignees

@frrist frrist

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gaps reported for epochs,tasks which already have an OK
2 participants
@frrist @placer14