chore(find): Refactor GapIndexer.findMissingTasksAndEpochs #778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
placer14
force-pushed
the
mg/chore/refactor-find-query
branch
from
e8c8b89 to
d66b221
Compare
No change in behavior of Find, minor edits to tests to tighten the expected for the test subject.
placer14
force-pushed
the
mg/chore/refactor-find-query
branch
from
d66b221 to
031bea0
Compare
frrist
reviewed
Nov 24, 2021
| default: | ||
| } | ||
| gh := abi.ChainEpoch(gap) | ||
| tsgap, err := node.ChainGetTipSetByHeight(ctx, gh, types.EmptyTSK) |
There was a problem hiding this comment.
This shouldn't be removed as doing so changes the behavior of the implementation. Gap find should probably continue to be aware of null rounds vs. gaps. A solution is outlined here: #767 (comment). I'd be fine with that landing as a part of this work, or as a follow-on.
There was a problem hiding this comment.
I've run out of time to resolve this today. Will look for some spare time over my break to fix it or when I return.
There was a problem hiding this comment.
As a part of this we should also label gaps resulting from undetected null rounds as NULLROUND-GAP or similar.
|
This work will be re-applied along with the TBD plan for #767. Closing as it is no longer needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does not change the behavior of the tests, only tightens the expectations to only the subjects being tested.
Refactor happens to fix #773 as well, so this test is included.