Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ID address handling in message pool #4368

Open
jennijuju opened this issue Oct 13, 2020 · 8 comments
Open

ID address handling in message pool #4368

jennijuju opened this issue Oct 13, 2020 · 8 comments
Labels
area/messages effort/hours Effort: Hours P1 P1: Must be resolved

Comments

@jennijuju
Copy link
Member

only allow send message to an ID address until the t0 address has been in the chain for 900 blocks

This is to avoid the block that the ID was allocated in is reverted due to network reorg

@jennijuju jennijuju changed the title When receiver is an ID address, check the period of and f0 address’s existence in the network before proceed the message When receiver is an ID address, check the period of f0 address’s existence in the network before proceed the message Oct 13, 2020
@Kubuxu Kubuxu changed the title When receiver is an ID address, check the period of f0 address’s existence in the network before proceed the message ID address handling in message pool Oct 21, 2020
@Kubuxu
Copy link
Contributor

Kubuxu commented Oct 21, 2020

Currently, if you send with From ID address we will replace it with public key address (type 1 or 3).
Proper solution for that is looking at state of init actor Finality back and checking what is the nextID in it to decide if we should use public key address or ID address.

@Kubuxu
Copy link
Contributor

Kubuxu commented Oct 21, 2020

The same should be applie to To address, replacing To address to ID address if ID of the To public key address is older than Finality and refusing to send with To ID address newer than Finality.

@arajasek
Copy link
Contributor

arajasek commented May 3, 2021

Slapping the mpool-management epic label on this, if it isn't covered there, we'll re-triage.

@BigLep
Copy link
Member

BigLep commented Jun 14, 2021

Per 2021-06-14 discussion, this will get closed after Hyperdrive.

@Kubuxu
Copy link
Contributor

Kubuxu commented Jul 12, 2021

@BigLep I don't think Hyperdrive solved this. Hyperdrive fixed some minor issues with ID address handling but it doesn't permit you to use ID addresses from Lotus. It also doesn't automatically use ID addresses when possible.

@Stebalien
Copy link
Member

Was this not fixed in #6364?

@Stebalien
Copy link
Member

But we probably need a test.

@jennijuju jennijuju added the P1 P1: Must be resolved label Dec 14, 2021
@jennijuju jennijuju added this to the v1.13.3 milestone Dec 14, 2021
@hunjixin
Copy link
Contributor

hunjixin commented Dec 27, 2021

is finality(900 height) a bit big for this issue? maybe message confidence value more suitable

@jennijuju jennijuju modified the milestones: v1.13.3, v1.15.0 Jan 2, 2022
@jennijuju jennijuju removed this from the v1.15.0 milestone Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/messages effort/hours Effort: Hours P1 P1: Must be resolved
Projects
None yet
Development

No branches or pull requests

7 participants