Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve address resolution for messages #6364

Merged
merged 6 commits into from
Jun 1, 2021
Merged

Improve address resolution for messages #6364

merged 6 commits into from
Jun 1, 2021

Conversation

arajasek
Copy link
Contributor

Basically changes various subcomponents to only think in terms of ID addresses (or key addresses).

Only open question is about Gateway:

  • Will renaming mpool provider's StateAccountKey to StateAccountKeyAtFinality break the gateway?
  • I guess there's no way to get it to use the stmgr's new finality lookback resolver without adding an explicit API call for it (urgh)

@magik6k magik6k merged commit 5a9e6c8 into feat/nv13 Jun 1, 2021
@magik6k magik6k deleted the asr/resolve-messages branch June 1, 2021 12:38
@Stebalien Stebalien mentioned this pull request Aug 17, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magik6k magik6k magik6k approved these changes

@Kubuxu Kubuxu Awaiting requested review from Kubuxu

@whyrusleeping whyrusleeping Awaiting requested review from whyrusleeping

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arajasek @magik6k @hunjixin