Checks to-address for finality before adding message to mempool #7795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoff-vball
force-pushed
the
feat/mempool-to-address-finality
branch
from
ff83c7c to
a5253fb
Compare
geoff-vball
force-pushed
the
feat/mempool-to-address-finality
branch
from
a5253fb to
c4e3222
Compare
arajasek
suggested changes
Dec 16, 2021
There was a problem hiding this comment.
So this doesn't quite work, unfortunately. StateAccountKeyAtFinality will fail if called with something that isn't a secp / bls account -- something like a miner actor doesn't have an "account key", although it does have a robust address.
I think we need to do the following:
- check if
Tois an ID address. If it is, - check if it existed 900 epochs ago. if it didn't,
- check if the
Toactor is an account. if it is, - fail: they should be using the pubkey address instead.
Really we should be failing even if the To actor isnt' an account, but that's gonna break a looot of tooling, so I'd rather just see this land first.
|
@arajasek feel like we should include this in v1.14.0? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes issue #4368