fix: chain: use latest go-state-types types for miner UI #11566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arajasek
force-pushed
the
asr/update-miner-gst
branch
from
85a30dc to
0516e71
Compare
Stebalien
approved these changes
Jan 11, 2024
| @@ -5875,12 +5875,12 @@ Response: | |||
| "InitialPledge": "0", | |||
| "ExpectedDayReward": "0", | |||
| "ExpectedStoragePledge": "0", | |||
| "ReplacedSectorAge": 10101, | |||
| "PowerBaseEpoch": 10101, | |||
There was a problem hiding this comment.
Is this not going to be an issue for API stability? And/or historical state?
There was a problem hiding this comment.
I'm honestly not sure? But it is a breaking change that we've had in the protocol itself, so I feel like the API needs to break too here.
There was a problem hiding this comment.
Yeah, it does need to change. I guess: do it and see if anyone cares?
arajasek
force-pushed
the
asr/update-miner-gst
branch
from
0516e71 to
5746c48
Compare
arajasek
force-pushed
the
asr/update-miner-gst
branch
from
5746c48 to
c86f5a1
Compare
Stebalien
approved these changes
Jan 11, 2024
|
The |
jimpick
pushed a commit
to glifio/go-pools
that referenced
this pull request
Jan 23, 2024
Requires Lotus build on master branch with this PR: * filecoin-project/lotus#11566
Schwartz10
added a commit
to glifio/go-pools
that referenced
this pull request
Jan 24, 2024
* Clean up types, delete unused code * More type cleanup * Fetch MinerInfo directly from state, not api * Return Vesting and pledged bal in PreviewTerminateSectorsReturn * Cleanup agent liquidation summary method * Add helper methods to the PreviewAgentTerminationSummary struct * Move test helpers to utils package * Add tests * Add Agent Liquid balance for ADO integration * Delete max withdraw query * Update mocks * Fix max borrow helpers Fix tests and tweak rr calc * Polish * Use new liquidation value in econ.ComputeAgentData * Prepare for set-recovered handling of faulty agents * Prepare for set-recovered with agents with bad LV's * Update types * Remove incomplete test * Fix AgentMaxBorrow * Add AgentCollateralStatsQuick method * Update types * Improve naming, add Summarize fn * Add LTV helper to PreviewATS struct * Updated off-chain termination calculation for network v12 Requires Lotus build on master branch with this PR: * filecoin-project/lotus#11566 * Use StateCall instead of StateCompute for on-chain terminations * Check early terminations in state for on-chain * Remove debug code * Update go sum * Change ComputeAgentData func sig * Add econ package tests * Remove old unused code * Update naming * Update use of WAD math --------- Co-authored-by: Jim Pick <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
@jimpick pointed out that the SectorOnChainInfo returned over the API has the wrong field names.
Proposed Changes
Use {{.latestVersion}} types which will keep us up to date.
Additional Info
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>fix: mempool: Introduce a cache for valid signaturesPR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps