Agent liquidation value #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix tests and tweak rr calc
Schwartz10
force-pushed
the
agent-liquidation-value
branch
from
d6cc8e7 to
b1cff63
Compare
Requires Lotus build on master branch with this PR: * filecoin-project/lotus#11566
jimpick
approved these changes
Jan 24, 2024
There was a problem hiding this comment.
Lots of changes!
Overall, looks really good. I reviewed and have a better understanding of how the termination penalties flow through the system. The economics calculations look well thought out, but I don't have complete understanding to say whether or not they are correct.
ganzai-san
reviewed
Jan 24, 2024
econ/econ.go
Outdated
| @@ -18,79 +18,60 @@ func ComputeAgentData( | |||
| sdk poolstypes.PoolsSDK, | |||
| agentLiquidAssets *big.Int, | |||
There was a problem hiding this comment.
Think we should phase out the liquid assets term and use agentAvailableBalance
ganzai-san
reviewed
Jan 24, 2024
econ/econ.go
Outdated
| if err != nil { | ||
| return nil, err | ||
| } | ||
| // here we replace the ats.AgentAvailableBal with the AgentLiquidAssets passed in this call to compute the post-action liquidation value |
There was a problem hiding this comment.
Confusing...available balance is the same as liquid balance just in this case liquid assets has the post-action value
ganzai-san
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.