Allow negative performing chains and reduce block packing when the basefee is sky high #3550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kubuxu
reviewed
Sep 4, 2020
| @@ -91,7 +98,7 @@ func (mp *MessagePool) republishPendingMessages() error { | |||
|
|
|||
| // we don't republish negative performing chains, as they won't be included in | |||
| // a block anyway | |||
| if chain.gasPerf < 0 { | |||
| if !allowNegative && chain.gasPerf < 0 { | |||
There was a problem hiding this comment.
As a note, we should republish slightly negative chains. Base fee can fall quite quickly.
There was a problem hiding this comment.
I didn't even think about this effect. In essence, miners who updated to 0.5.10 won't re-pub messages.
There was a problem hiding this comment.
Not sure about that, we might as well wait for the next republish interval.
There was a problem hiding this comment.
But yeah, the effect is real -- and I didn't even think about it either.
Signed-off-by: Jakub Sztandera <[email protected]>
vyzo
force-pushed
the
fix/mpool-basefee-control
branch
from
8d18778 to
c068bc9
Compare
|
rebased on master. |
|
it's a lost cause, we'll have real incentives by uncapping the miner penalty in the next 2 forks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.