Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug that can't package priority message when other's gasPerf is n… #3575

Conversation

IPFSMain-Official
Copy link

The messages of priority addr won't be packaged when all the chain gasPerf are negative of the other's message

@vyzo
Copy link
Contributor

vyzo commented Sep 5, 2020

We don't consider this a bug.
We are considering however allowing negative perf chains when the base fee is too high -- see also #3550

@vyzo
Copy link
Contributor

vyzo commented Sep 5, 2020

oooh, I see -- sorry misread this.
Yes, this is indeed a bug, thanks for spotting!

@vyzo
Copy link
Contributor

vyzo commented Sep 5, 2020

Your PR can't be merged as is however, because it is breaking the test-vectors extern dependency.

@vyzo
Copy link
Contributor

vyzo commented Sep 5, 2020

cherry picked in #3580 to fix the dirty diff issues.

@vyzo vyzo closed this Sep 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants