-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NV18: FEVM implementation #9617
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make it use GasEstimateMessageGas, which applies overestimation by default. This accounts for inclusion costs.
Also updates the actors to accommodate this change, and fix a bug in looking up addresses for f4 actors.
Co-authored-by: Raúl Kripalani <[email protected]>
We need to add full FEVM state support, but that will require merging master. This is enough for now. fixes filecoin-project/ref-fvm#1022
and skip a non-testing test; printing doesn't constitute testing.
This was referenced Nov 10, 2022
Merged
Only when actors version is >= 10
it breaks the gen script in proxy_gen
it's in the actor state only if it is a v5 (or later) state tree
it's a dummy, but at least it makes tests pass
We now create the 0x0 Eth null address on genesis as an EthAccount, so using the 0x0 Eth null address is guaranteed to work.
1. Move contract deployment and invocation commands to the "eth" command group. 2. Remove the hack to use EAM#Create2 for an external contract creation. 3. Remove code made stale as a result of these refactors.
…ig + cleanups (#9970) Co-authored-by: raulk <[email protected]>
… and conversion methods (#9992)
TODO:
Some done, others tracked as |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherrypicks the
experimental/fvm-m2
(see #8803) branch to bring all FEVM related functionality into nv18.