eth: rpc: various Ethereum JSON-RPC API fixes #9837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ychiaoli18
changed the title
raulk
reviewed
Dec 14, 2022
api/eth_types.go
Outdated
| @@ -83,6 +83,9 @@ func (e EthBytes) MarshalJSON() ([]byte, error) { | |||
| if len(e) == 0 { | |||
| return json.Marshal("0x") | |||
| } | |||
| if len(e) == 1 && e[0] == 0 { | |||
There was a problem hiding this comment.
What case does this deal with? Where do we return a non-nil byte string with a single 0 byte (which is different to an empty byte string).
There was a problem hiding this comment.
This should be removed, and the type of R, S, V should be big.Int instead of bytes. The empty value of big.Int should be 0x0 and the empty value of bytes should be 0x
raulk
changed the title
raulk
reviewed
Dec 19, 2022
| @@ -63,6 +63,52 @@ func TestTxArgs(t *testing.T) { | |||
| } | |||
| } | |||
|
|
|||
| func TestSignatures(t *testing.T) { | |||
This was referenced Dec 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Fixes filecoin-project/ref-fvm#1016
Fixes filecoin-project/ref-fvm#1158
Fixes filecoin-project/ref-fvm#1196
Fixes filecoin-project/ref-fvm#1269
Fixes filecoin-project/ref-fvm#1135.
Fixes #9820
Proposed Changes
Additional Info
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>fix: mempool: Introduce a cache for valid signaturesPR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps