Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eth_getTransactionBy* - RPC incompatibility, null fields should return 0x0 #1269

Closed
jaeaster opened this issue Dec 13, 2022 · 2 comments
Closed

eth_getTransactionBy* - RPC incompatibility, null fields should return 0x0 #1269

jaeaster opened this issue Dec 13, 2022 · 2 comments
Assignees
@ychiaoli18
Labels
Lotus Topic: Ethereum JSON-RPC
Milestone
M2.1 Testing

Comments

@jaeaster
Copy link

In ethers-rs, when trying to deserialize the response from eth_getTransactionBy(Hash, BlockNumberAndIndex, BlockHashAndIndex), the deserialization fails because the ECDSA fields (r, s, v) are all equal to 0x. ethers-rs expects those fields to be populated with some value, namely:

"invalid length 0, expected a (both 0x-prefixed or not) hex string or byte array containing between (0; 8] bytes"

I'm not sure if those fields should be null, but if they are, the RPC should return 0x0. I've tested that filling those fields with 0x0 results in a successful deserialization.
@Stebalien Stebalien added this to the M2.1 (rr10) Carbonado milestone Dec 13, 2022
@Stebalien
Copy link
Member

Yep. We need to be revers-engineering these fields from the signature in https://github.com/filecoin-project/lotus/blob/373b8b3517c6ade6f9d346bfe3c0af30007f2b47/node/impl/full/eth.go#L1483-L1485. But we're not.

@ychiaoli18 ychiaoli18 mentioned this issue Dec 13, 2022
Merged
7 tasks
raulk pushed a commit to filecoin-project/lotus that referenced this issue Dec 19, 2022
@ychiaoli18
eth: rpc: various Ethereum JSON-RPC API fixes (#9837)
20f27af 
Co-authored-by: Raúl Kripalani <[email protected]>
Fixes filecoin-project/ref-fvm#1016
Fixes filecoin-project/ref-fvm#1158
Fixes filecoin-project/ref-fvm#1196
Fixes filecoin-project/ref-fvm#1269
Fixes #9820
@raulk
Copy link
Member

raulk commented Dec 19, 2022

Fixed in filecoin-project/lotus#9837.

@raulk raulk closed this as completed Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ychiaoli18 ychiaoli18

Labels
Lotus Topic: Ethereum JSON-RPC
Projects
None yet
Milestone
M2.1 Testing
Development

No branches or pull requests
5 participants
@Stebalien @raulk @ychiaoli18 @jaeaster @jennijuju