Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs to publish to calm.finos.org via s3 and configure to use … #493

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

rocketstack-matt
Copy link
Member

…Git LFS for .mov files.

Resolves #491

@rocketstack-matt rocketstack-matt requested a review from a team as a code owner October 18, 2024 10:41
@rocketstack-matt
Copy link
Member Author

Will remove the GitHub Pages publishing in a later PR assuming this all publishes as expected

@Thels
Copy link
Member

Thels commented Oct 18, 2024

First time seeing a .mov as part of a PR - next up is the entire Shrek movie!

Copy link
Member

@Thels Thels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks fine - I worry that if we add more folders into docs that we will forget to update s3-docs-sync.yml and end up publishing things we shouldn't to the FINOS S3 bucket but it's a small risk that is mitigated by proper review processes.

@rocketstack-matt
Copy link
Member Author

Overall looks fine - I worry that if we add more folders into docs that we will forget to update s3-docs-sync.yml and end up publishing things we shouldn't to the FINOS S3 bucket but it's a small risk that is mitigated by proper review processes.

Everything in docs would automatically get included in the sync. The excludes are to prevent the --delete flag from removing other directories we sync (draft and samples); this is because we're copying to contents of docs/build to root rather than into it's own subdir.

@rocketstack-matt rocketstack-matt merged commit 0e5cee4 into finos:main Oct 18, 2024
2 checks passed
@rocketstack-matt rocketstack-matt deleted the s3-docs branch October 18, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publish CALM docs to calm.finos.org
2 participants