Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to filter by CVE details on software/versions page #24765

Open
jmwatts opened this issue Dec 13, 2024 · 2 comments
Open

Unable to filter by CVE details on software/versions page #24765

jmwatts opened this issue Dec 13, 2024 · 2 comments
Labels
bug Something isn't working as documented #g-endpoint-ops Endpoint ops product group :incoming New issue in triage process. :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. ~unreleased bug This bug was found in an unreleased version of Fleet.
Milestone

Comments

@jmwatts
Copy link
Member

jmwatts commented Dec 13, 2024

Fleet version: v4.61.0

Web browser and operating system: Chrome 131.0.6778.110 on macOS


💥  Actual behavior

Spinner, error message is shown. Error in log (see More info)

🧑‍💻  Steps to reproduce

On Fleet PREMIUM instance:

  1. Go to Software >> enable the "Show versions" toggle
  2. In "Add filters" toggle on "Vulnerable software", choose a severity, check "Has known exploit"
  3. Click Apply

🕯️ Expected

Page loads with filters applied

🕯️ More info (optional)

Screenshot 2024-12-13 at 2 19 40 PM
Screenshot 2024-12-13 at 2 19 47 PM

level=error ts=2024-12-13T20:09:06.748592Z component=http [email protected] method=GET uri="/api/latest/fleet/software/versions?page=0&per_page=20&order_direction=desc&order_key=hosts_count&team_id=12&vulnerable=true&exploit=true&min_cvss_score=0.1&max_cvss_score=3.9&without_vulnerability_details=true" took=957.625µs err="Requires Fleet Premium license" uuid=12435b5f-0034-4caa-96fc-1f9d7d8c4379
level=error ts=2024-12-13T20:09:07.849542Z component=http [email protected] method=GET uri="/api/latest/fleet/software/versions?page=0&per_page=20&order_direction=desc&order_key=hosts_count&team_id=12&vulnerable=true&exploit=true&min_cvss_score=0.1&max_cvss_score=3.9&without_vulnerability_details=true" took=489.208µs err="Requires Fleet Premium license" uuid=12435b5f-0034-4caa-96fc-1f9d7d8c4379
level=debug ts=2024-12-13T20:09:07.910052Z component=http method=POST uri=/api/v1/osquery/config took=9.344333ms ip_addr=47.32.18.149 x_for_ip_addr=47.32.18.149
level=debug ts=2024-12-13T20:09:08.35997Z component=http method=POST uri=/api/v1/osquery/distributed/read took=1.451292ms ip_addr=47.32.18.149 x_for_ip_addr=47.32.18.149
level=error ts=2024-12-13T20:09:10.009409Z component=http [email protected] method=GET uri="/api/latest/fleet/software/versions?page=0&per_page=20&order_direction=desc&order_key=hosts_count&team_id=12&vulnerable=true&exploit=true&min_cvss_score=0.1&max_cvss_score=3.9&without_vulnerability_details=true" took=359µs err="Requires Fleet Premium license" uuid=12435b5f-0034-4caa-96fc-1f9d7d8c4379
level=error ts=2024-12-13T20:09:14.183019Z component=http [email protected] method=GET uri="/api/latest/fleet/software/versions?page=0&per_page=20&order_direction=desc&order_key=hosts_count&team_id=12&vulnerable=true&exploit=true&min_cvss_score=0.1&max_cvss_score=3.9&without_vulnerability_details=true" took=597.375µs err="Requires Fleet Premium license" uuid=12435b5f-0034-4caa-96fc-1f9d7d8c4379
level=debug ts=2024-12-13T20:09:14.300248Z component=http [email protected] method=GET uri="/api/latest/fleet/software/titles?page=0&per_page=20&order_direction=desc&order_key=hosts_count&team_id=12&available_for_install=true&vulnerable=true&exploit=true&min_cvss_score=0.1&max_cvss_score=3.9" took=26.41575ms
@jmwatts jmwatts added bug Something isn't working as documented :reproduce Involves documenting reproduction steps in the issue :incoming New issue in triage process. :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. ~unreleased bug This bug was found in an unreleased version of Fleet. and removed :reproduce Involves documenting reproduction steps in the issue labels Dec 13, 2024
@jmwatts jmwatts added this to the 4.61.0 milestone Dec 13, 2024
@jmwatts jmwatts added the #g-endpoint-ops Endpoint ops product group label Dec 13, 2024
@iansltx
Copy link
Member

iansltx commented Dec 13, 2024

Test scenarios (pasted from Slack; h/t @ksykulev)

fleet free
-> no vulnerability filter

  • &without_vulnerability_details=false - should ignore and still show without details
  • &without_vulnerability_details=true - should show without details
    -> vulnerability filter
  • &without_vulnerability_details=false - should ignore and still show without details
  • &without_vulnerability_details=true - should show without details

fleet premium
-> no vulnerability filter

  • &without_vulnerability_details=false - doesn't show details

  • &without_vulnerability_details=true - doesn't show details, is performant
    -> vulnerability filter

  • &without_vulnerability_details=false - shows details, is heavy for large page sizes

  • &without_vulnerability_details=true - doesn't show details, is slightly less heavy for large page sizes

  • Also should test Free with vulnerability filters to confirm that we get license errors there.

ksykulev added a commit that referenced this issue Dec 13, 2024
…y filters (#24769)

#24765

# Checklist for submitter

If some of the following don't apply, delete the relevant line.

<!-- Note that API documentation changes are now addressed by the
product design team. -->

- [x] Changes file added for user-visible changes in `changes/`,
`orbit/changes/` or `ee/fleetd-chrome/changes`.
See [Changes
files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/Committing-Changes.md#changes-files)
for more information.
- [x] Added/updated tests
ksykulev added a commit that referenced this issue Dec 13, 2024
…y filters (#24769)

#24765

# Checklist for submitter

If some of the following don't apply, delete the relevant line.

<!-- Note that API documentation changes are now addressed by the
product design team. -->

- [x] Changes file added for user-visible changes in `changes/`,
`orbit/changes/` or `ee/fleetd-chrome/changes`.
See [Changes
files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/Committing-Changes.md#changes-files)
for more information.
- [x] Added/updated tests
iansltx pushed a commit that referenced this issue Dec 13, 2024
@jmwatts
Copy link
Member Author

jmwatts commented Dec 14, 2024

QA Notes:

Per test plan in comment above, as well as UI validation that all features/filters are functional as appropriate for Fleet free vs Fleet Premium, this issue has been resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as documented #g-endpoint-ops Endpoint ops product group :incoming New issue in triage process. :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. ~unreleased bug This bug was found in an unreleased version of Fleet.
Development

No branches or pull requests

2 participants