Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-Pick: Fixed bug when using without_vulnerability_details and vulnerability filters #24774

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

ksykulev
Copy link
Contributor

issue #24765
original pr #24769

…y filters (#24769)

#24765

# Checklist for submitter

If some of the following don't apply, delete the relevant line.

<!-- Note that API documentation changes are now addressed by the
product design team. -->

- [x] Changes file added for user-visible changes in `changes/`,
`orbit/changes/` or `ee/fleetd-chrome/changes`.
See [Changes
files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/Committing-Changes.md#changes-files)
for more information.
- [x] Added/updated tests
@ksykulev ksykulev requested a review from a team as a code owner December 13, 2024 22:40
@iansltx iansltx changed the title Fixed bug when using without_vulnerability_details and vulnerability filters Cherry-Pick: Fixed bug when using without_vulnerability_details and vulnerability filters Dec 13, 2024
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.

Please upload report for BASE (rc-minor-fleet-v4.61.0@b2ad1b3). Learn more about missing BASE report.

Files with missing lines Patch % Lines
server/service/software.go 40.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@                    Coverage Diff                    @@
##             rc-minor-fleet-v4.61.0   #24774   +/-   ##
=========================================================
  Coverage                          ?   63.54%           
=========================================================
  Files                             ?     1590           
  Lines                             ?   150841           
  Branches                          ?     3759           
=========================================================
  Hits                              ?    95855           
  Misses                            ?    47345           
  Partials                          ?     7641           
Flag Coverage Δ
backend 64.38% <57.14%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iansltx iansltx merged commit d4b91e3 into rc-minor-fleet-v4.61.0 Dec 13, 2024
22 checks passed
@iansltx iansltx deleted the 24765-version-bugfix-cherry-pick branch December 13, 2024 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants