Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TO RC: UI - Host filters bug (#22132) #22141

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Conversation

jacobshandling
Copy link
Contributor

This PR already merged to main, see #22132. This is against the release branch so it can be included in 4.57.0 (issue #22088 )

## #22088 

- Hosts page filters were using the same type that had been updated with
additional, more granular options, but the filters for that page still
only support the aggregate options "install", "pending" or "failed".
Updated hosts page to use new type `SoftwareAggregateStatus` to maintain
functionality.
- Note that this does _not_ fix this related but distinct _released_
bug: #22136

- [x] Manual QA for all new/changed functionality

---------

Co-authored-by: Jacob Shandling <[email protected]>
Copy link

codecov bot commented Sep 16, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Please upload report for BASE (minor-fleet-v4.57.0@9eaf6c7). Learn more about missing BASE report.

Files with missing lines Patch % Lines
frontend/interfaces/software.ts 60.00% 2 Missing ⚠️
frontend/utilities/url/index.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                   @@
##             minor-fleet-v4.57.0   #22141   +/-   ##
======================================================
  Coverage                       ?   65.34%           
======================================================
  Files                          ?     1493           
  Lines                          ?   116656           
  Branches                       ?     3485           
======================================================
  Hits                           ?    76233           
  Misses                         ?    33308           
  Partials                       ?     7115           
Flag Coverage Δ
frontend 52.01% <50.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jacobshandling jacobshandling merged commit e96d5cc into minor-fleet-v4.57.0 Sep 17, 2024
11 checks passed
@jacobshandling jacobshandling deleted the 22088-to-rc branch September 17, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants