CHORE: Move page.window_* and page.browser_context_menu_* properties to Window and BrowserContextMenu classes

[ndonkoHenri]

Description

• Moved page.window_* and page.browser_context_menu_* properties to Window and BrowserContextMenu classes respectively
• Deprecated page.window_* props in favor of page.window.*
• Exposed some more properties of the window_manager packages (shadow, alignment, wait_until_ready_to_show, always_on_bottom, icon, badge_label)

Fixes #3414

Test Code

import flet as ft


def main(page: ft.Page):
    page.window_always_on_top = True  # deprecated
    page.window.title = "Hello, World!"
    page.window.on_event = lambda e: print(e.type)
    page.on_resize = lambda e: print(e.width, e.height)  # deprecated
    page.window.shadow = True  # new
    page.window.badge_label = "2"  # new (macos only)
    page.window.alignment = ft.alignment.center_right  # new
    page.window.always_on_bottom = False  # new
    page.window.wait_until_ready_to_show = True  # new

    page.add(
        ft.Text("Hello, World!", size=30),
    )


ft.app(target=main)

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

Checklist:

• I signed the CLA.
• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• My changes generate no new warnings

• New and existing tests pass locally with my changes
• I have made corresponding changes to the documentation (if applicable)

Screenshots (if applicable):

Additional details

page.window.icon was added but not tested since it is windows-only (which I don't have)

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request refactors the page class by moving page.window_* and page.browser_context_menu_* properties to new Window and BrowserContextMenu classes respectively. It also introduces deprecation warnings for the old page.window_* properties, advising the use of the new page.window.* properties.

File-Level Changes

Files	Changes
sdk/python/packages/flet-core/src/flet_core/page.py sdk/python/packages/flet-core/src/flet_core/types.py sdk/python/packages/flet-core/src/flet_core/utils/deprecated.py	Refactored page class to use new Window and BrowserContextMenu classes, added deprecation warnings, and introduced WindowEventType enum.
packages/flet/lib/src/controls/page.dart packages/flet/lib/src/utils/desktop.dart	Updated Flutter code to handle new Window properties and methods, including alignment, badge label, icon, shadow, and always on bottom.

---

Tips

• Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
• You can change your review settings at any time by accessing your dashboard:
  • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
  • Change the review language;
• You can always contact us if you have any questions or feedback.

[sourcery-ai]

Hey @ndonkoHenri - I've reviewed your changes and found some issues that need to be addressed.

Blocking issues:

• Typo in property name (link)

Here's what I looked at during the review

• 🔴 General issues: 1 blocking issue, 2 other issues
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟡 Complexity: 1 issue found
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.}

[sourcery-ai]

suggestion: Use of time.time() for unique values

Using time.time() to generate unique values might not be reliable in all cases. Consider using a more robust method for generating unique identifiers.

Suggested change

	self.page._set_attr("windowCenter", str(time.time()))
	import uuid
	self.page._set_attr("windowCenter", str(uuid.uuid4()))

[ndonkoHenri]

@FeodorFitsner, wdyt?

[FeodorFitsner]

That makes sense.