-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT: expose missing py-events in Map
#3464
Conversation
Reviewer's Guide by SourceryThis pull request adds missing map events to the Python end of the File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ndonkoHenri - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 6 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
…ies to `Window` and `BrowserContextMenu` classes (#3463) * initial commit * commit * update Window * create BrowserContextMenu class * chore: remove deprecation_warning and reformat deprecated * change signal to SIG_DFL after exit_gracefully (#3466) * improve type hint for run_task and run_thread (#3459) * add type hint * fix Future[RetT] * feat(map): add missing py-events, better typing (#3464) * initial commit * commit * update Window * create BrowserContextMenu class * chore: remove deprecation_warning and reformat deprecated * Geolocator: rename some classes and methods --------- Co-authored-by: Zhan Rongrui <[email protected]>
…ies to `Window` and `BrowserContextMenu` classes (flet-dev#3463) * initial commit * commit * update Window * create BrowserContextMenu class * chore: remove deprecation_warning and reformat deprecated * change signal to SIG_DFL after exit_gracefully (flet-dev#3466) * improve type hint for run_task and run_thread (flet-dev#3459) * add type hint * fix Future[RetT] * feat(map): add missing py-events, better typing (flet-dev#3464) * initial commit * commit * update Window * create BrowserContextMenu class * chore: remove deprecation_warning and reformat deprecated * Geolocator: rename some classes and methods --------- Co-authored-by: Zhan Rongrui <[email protected]>
Description
Some map events where added on dart end, but forgotten on py end.
Type of change
Checklist:
Summary by Sourcery
This pull request introduces new event handlers for various map interactions, including position changes and pointer events. It also refactors existing event handling to use more specific event classes and updates several map-related classes to use a unified event callback type.
on_position_change
,on_pointer_down
,on_pointer_cancel
, andon_pointer_up
in theMapInteractionConfiguration
class.MapPointerDeviceType
enum to represent different types of pointer devices.MapTapEvent
,MapPositionChangeEvent
, andMapPointerEvent
to handle specific map events.MapInteractionConfiguration
to use specific event classes likeMapTapEvent
andMapEvent
.SimpleAttribution
,TextSourceAttribution
, andTileLayer
classes to useOptionalEventCallback
for event handlers.