Port of PR #72 to new master #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Resolves issue flexible-collision-library#67 - Port of 49edfc6 by @ricardoglc to new master
- Partial port of 8d0441e by @ricardoglc
jslee02
requested changes
Nov 10, 2017
There was a problem hiding this comment.
Thanks for this change!
Could you add (std::nothrow) to https://github.com/flexible-collision-library/fcl/pull/237/files#diff-0e6130d1d4ac9b019f5e8c53c4f3aaabR478 as well?
include/fcl/geometry/bvh/BVH_model.h
Outdated
| @@ -40,6 +40,7 @@ | |||
|
|
|||
| #include <vector> | |||
| #include <memory> | |||
| #include <new> | |||
There was a problem hiding this comment.
Nit: It would be good to move this to BVH_model-inl.h as BVH_model-inl.h actually uses this header.
|
It seems Eigen objects are not supposed to be used with |
jslee02
approved these changes
Nov 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a partial port of PR #72 by @ricardoglx to the current master. It does not include the getOctree accessors but should be a partial or full fix for #67.