Fix failure in building point cloud models for OBB/RSS/kIOS/OBBRSS (issue #67) #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 for the test passing, but I'm not very familiar with the details of what has changed, so I'll wait for someone else to review as well. |
| boost::shared_ptr<octomap::OcTree> getTree() | ||
| { | ||
| return tree; | ||
| } |
There was a problem hiding this comment.
It seems this accessor is added to address #73, which looks good to me. It would also good to provide const version of getTree() for const correctness as:
boost::shared_ptr<const octomap::OcTree> getTree() const
{
return tree;
}There was a problem hiding this comment.
We might be able to add this later.
|
👍 I believe this pull request is ready to merge. |
|
I'd like to merge this unless someone has an objection. @ricardoglc could you resolve the confliction so that we could merge this? |
|
Close in favor of #237 |
jslee02
pushed a commit
that referenced
this pull request
Nov 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The functions beginModel, addTriangle and addSubModel now respect documentation, keeping tri_indices as NULL for point clouds. This fixes issue #67 .