Backport(v1.16): config: yaml_parser: Handle $log_level element for special case (#4482) #4486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, CI is failed due to a change of dependent gem. It seems that console gem is needed pinned. |
I have made the issue for this: We should resolve this first. |
daipom
force-pushed
the
v1.16-backport-4482
branch
from
26d5a3e
to
2ff5905
Compare
Backported from 236d87d. --- This is because `@log_level` is invalid for YAML. Instead, we should interpret $log_level as `@log_level` on YAML parser. Signed-off-by: Hiroshi Hatake <[email protected]>
daipom
force-pushed
the
v1.16-backport-4482
branch
from
2ff5905
to
2020531
Compare
ashie
approved these changes
Jun 7, 2024
daipom
added a commit
that referenced
this pull request
Aug 20, 2024
Signed-off-by: Daijiro Fukuda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backported from 236d87d. (#4482)