Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a failed test of ConsoleAdapter #4477

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Conversation

ashie
Copy link
Member

@ashie ashie commented Apr 30, 2024

Which issue(s) this PR fixes:
N/A

What this PR does / why we need it:
Follow the change of the log format as of console v1.24.

Docs Changes:
N/A

Release Note:
N/A

Follow the change of the log format as of console v1.24.

Signed-off-by: Takuro Ashie <[email protected]>
@ashie ashie requested a review from daipom April 30, 2024 01:32
Copy link
Contributor

@daipom daipom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for this fix!

@daipom daipom merged commit a226e28 into master Apr 30, 2024
12 of 16 checks passed
@daipom daipom deleted the fix-console-adapter-test branch April 30, 2024 02:05
@ashie ashie added this to the v1.17.0 milestone Apr 30, 2024
@daipom daipom modified the milestones: v1.17.0, v1.16.6 May 7, 2024
@daipom
Copy link
Contributor

daipom commented May 7, 2024

We need to backport this to v1.16

daipom pushed a commit that referenced this pull request May 7, 2024
Backported from a226e28.

---

Follow the change of the log format as of console v1.24.

Signed-off-by: Takuro Ashie <[email protected]>
@daipom daipom modified the milestones: v1.16.6, v1.17.0 Aug 15, 2024
@daipom daipom added the backport to LTS We will backport this fix to the LTS branch label Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport to LTS We will backport this fix to the LTS branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants