Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport(v1.16): Fix a failed test of ConsoleAdapter (#4477) #4489

Closed
wants to merge 1 commit into from

Conversation

daipom
Copy link
Contributor

@daipom daipom commented May 7, 2024

Backported from a226e28. (#4477)

Backported from a226e28.

---

Follow the change of the log format as of console v1.24.

Signed-off-by: Takuro Ashie <[email protected]>
@daipom
Copy link
Contributor Author

daipom commented May 7, 2024

This fixes the CI failures for Ruby v3.0. (related to console gem v1.24)

For Ruby v3.1, 3.2, and 3.3, we need to consider #4487. (related to console gem v1.25)

@daipom
Copy link
Contributor Author

daipom commented May 28, 2024

The following PR will solve this issue on v1.16, so we don't need this backport.

@daipom daipom closed this May 28, 2024
@daipom daipom deleted the v1.16-backport-4477 branch May 29, 2024 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants