Dictionary access incorrectly triggers CollectionShouldHaveElementAt suggestion

[samcragg]

I'm using FluentAssertions version 5.4.0 and FluentAssertions.Analyzers version 0.10.1. When I create a test that asserts the values in dictionaries, the analyzer incorrectly suggests I use HaveElementAt which doesn't compile, i.e. given this code:

[Fact]
public void DictionaryTest()
{
    var dictionary = new Dictionary<string, int> { ["123"] = 123 };
    dictionary["123"].Should().Be(123);
}

The analyzer incorrectly suggests:

[Fact]
public void DictionaryTest()
{
    var dictionary = new Dictionary<string, int> { ["123"] = 123 };
    dictionary.Should().HaveElementAt("123", 123);
}

Perhaps it could suggest (though it's not simplifying but is more idiomatic):

dictionary.Should().ContainKey("123").WhichValue.Should().Be(123);

Happy to take a stab at a PR

[jnyrup]

Just as a note.
Fluent Assertions also has a shorthand for

dictionary.Should().ContainKey(key).WhichValue.Should().Be(value);

dictionary.Should().Contain(key, value);

See https://fluentassertions.com/documentation/#dictionaries

[Meir017]

@samcragg I'll be happy to receive a pull-request for this 😄

I think the solution should be to make the CollectionShouldHaveElementAtAnalyzer class (or even CollectionAnalyzer) method ShouldAnalyzeVariableType be more strict and exclude Dictionary

• make sure you run just the tests with the Completed category