Ignore dictionary types from HaveElementAt #45
Conversation
| @@ -27,6 +28,16 @@ protected override IEnumerable<FluentAssertionsCSharpSyntaxVisitor> Visitors | |||
| } | |||
| } | |||
|
|
|||
| protected override bool ShouldAnalyzeVariableType(ITypeSymbol type) | |||
| { | |||
| if (type.AllInterfaces.Any(@interface => @interface.Name == "IReadOnlyDictionary" || @interface.Name == "IDictionary")) | |||
There was a problem hiding this comment.
Since the dictionary assertions are on the type IDictionary I think this should not look for the readonly one
There was a problem hiding this comment.
That's correct, however, this is preventing the HaveIndexAt one from incorrectly firing on dictionaries. Since IDictionary doesn't inherit IReadOnlyDictionary I've done two checks (I use IReadOnlyDictionary in my interfaces which is where I found the bug).
| @@ -414,6 +414,14 @@ public class CollectionTests | |||
| [Implemented] | |||
| public void CollectionShouldNotBeNullOrEmpty_TestCodeFix(string oldAssertion, string newAssertion) => VerifyCSharpFixCodeBlock<CollectionShouldNotBeNullOrEmptyCodeFix, CollectionShouldNotBeNullOrEmptyAnalyzer>(oldAssertion, newAssertion); | |||
|
|
|||
| [TestMethod] | |||
| [Implemented] | |||
| public void CollectionShouldHaveElementAt_ShouldIgnoreDictionaryTypes() | |||
There was a problem hiding this comment.
I think this should be in the sanity tests and linked to its github issue
There was a problem hiding this comment.
Not a problem, didn't see that file 🙂
| @@ -27,6 +28,16 @@ protected override IEnumerable<FluentAssertionsCSharpSyntaxVisitor> Visitors | |||
| } | |||
| } | |||
|
|
|||
| protected override bool ShouldAnalyzeVariableType(ITypeSymbol type) | |||
There was a problem hiding this comment.
Can we move this to the collection analyzer without breaking tests?
There was a problem hiding this comment.
I think we do want some of the collection ones to still trigger on dictionaries (e.g. Should().BeEmpty())
|
@samcragg Thank you for your contribution 👍 |
This fixes #44 (thanks for the pointer of where to fix it!)