Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NBA Showtime: NBA on NBC - BGM cuts out after start #1249

Closed
kihato opened this issue Oct 17, 2023 · 4 comments
Closed

NBA Showtime: NBA on NBC - BGM cuts out after start #1249

kihato opened this issue Oct 17, 2023 · 4 comments
Labels
audio Audio input/output related issue bug Something isn't working

Comments

@kihato
Copy link

kihato commented Oct 17, 2023

Platform / OS / Hardware:
Windows11 / i7-10700F / GTX 1660 SUPER

Github hash: e96b38f

After pressing Start on the title screen, if you do nothing for a while on the option selection screen or team selection screen, the BGM may be interrupted or temporarily become inaudible.
Strangely enough, if I move the cursor periodically, the background music repeats normally.
@kihato kihato added the bug Something isn't working label Oct 17, 2023
@flyinghead flyinghead added the audio Audio input/output related issue label Oct 17, 2023
@kihato
Copy link
Author

kihato commented Dec 30, 2023

When I looked into the code, it seems that disabling the channel with AEG's EG_Release causes a bug in the BGM.
I don't know if it affects other games, but at least in this game, if you comment out ch->disable() here, the BGM will play normally.

@kihato
Copy link
Author

kihato commented Dec 31, 2023

Further testing yielded good results in the following games.
As for "Ready 2 Rumble Boxing", it's better than before, but the audio sometimes seems to disappear.

Ready 2 Rumble Boxing: #1030
Confidential Mission: #472
The Maze of the Kings: #483
Spikers Battle: #1180

flyinghead added a commit that referenced this issue Dec 31, 2023
@flyinghead
aica: don't disable channel when reaching full attenuation
a7702c6 
Some games rely on the channel still being processed and CA/LP being
updated. Courtesy of @kihato
Issues #472, #483, #1180, #1249, #1030 (partial)
@flyinghead
Copy link
Owner

Great find! It looks like this fixes a number of audio issues.
Should be fixed in the latest dev build.

@kihato
Copy link
Author

kihato commented Jan 3, 2024

I forgot to close this issue. Thanks!

@kihato kihato closed this as completed Jan 3, 2024
flyinghead added a commit that referenced this issue Aug 29, 2024
@flyinghead
aica: reset CA to 0 when disabling channel due to AEG
b468c9b 
CA was reset to 0 for non-looping sound when ending, but not for looping
ones when they reach full attenuation. This confuses some games.
Disable the channel when it reaches full attenuation and reset CA to 0.
Revert a7702c6
Issue #1602
Better fix for
Issues #472, #483, #1180, #1249, #1030 (partial)
@flyinghead flyinghead mentioned this issue Aug 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
audio Audio input/output related issue bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kihato @flyinghead