Confidential Mission - Missing sounds

[dukeblooders]

Some sounds, especially the reload one, are skipped/not played on Naomi and Dreamcast.

It starts at the beginning of the game, just after the first corner.

Configuration : Windows 10, flycast standalone (latest nightly)

[flyinghead]

Some reload sounds are missing at some times. However it seems to be intermittent. Same behavior in dreamcast and Naomi versions.

[flyinghead]

Should be fixed in the latest dev build.

[dukeblooders]

Tested with the latest dev build and it works like a charm!

Thanks

[kihato]

Unfortunately, there was a regression caused by b468c9b.
However, it seems to only affect #472 and #1180.

[kihato]

It seems that enabled=false in disable() affects #472 and #1180.
So I tried setting ch->CA=0 in EG_Release.
I tested it in this state and there were no more reboots or audio issues.

[flyinghead]

I might have a clue as to why disabling the channel causes problems: after AegStep() is called and disables the channel because max attenuation is reached, StreamStep() is still called and will decode one or more samples and increase CA.
One solution would be to test if the channel has been disabled in ChannelEx::Step() and avoid calling other step functions if this is the case:

                        StepAEG(this);
-                       StepFEG(this);
-                       StepStream(this);
-                       lfo.Step(this);
+                       if (enabled)
+                       {
+                               StepFEG(this);
+                               StepStream(this);
+                               lfo.Step(this);
+                       }

Can you test this change? (I'm having a hard time reproducing this issue consistently)

[kihato]

Awesome!
It worked perfectly fine for #472, #1180 and other issues(#483, #1249, #1030, #1602, #1272) too.

[flyinghead]

Fixed on master