Skip to content

Commit

Permalink
Add 'additionalContainers' value for flyteadmin (#2834)
Browse files Browse the repository at this point in the history
Signed-off-by: Andrew Dye <[email protected]>

Signed-off-by: Andrew Dye <[email protected]>
  • Loading branch information
andrewwdye authored Sep 1, 2022
1 parent 1f9c13c commit 170e925
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 0 deletions.
1 change: 1 addition & 0 deletions charts/flyte-core/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,7 @@ helm install gateway bitnami/contour -n flyte
| db.datacatalog.database.username | string | `"postgres"` | |
| deployRedoc | bool | `false` | |
| external_events | object | `{"aws":{"region":"us-east-2"},"enable":false,"eventsPublisher":{"eventTypes":["all"],"topicName":"arn:aws:sns:us-east-2:123456:123-my-topic"},"type":"aws"}` | **Optional Component** External events are used to send events (unprocessed, as Admin see them) to an SNS topic (or gcp equivalent) The config is here as an example only - if not enabled, it won't be used. |
| flyteadmin.additionalContainers | object | `{}` | Appends additional containers to the containers list. May include template values. |
| flyteadmin.additionalVolumeMounts | list | `[]` | |
| flyteadmin.additionalVolumes | list | `[]` | |
| flyteadmin.affinity | object | `{}` | affinity for Flyteadmin deployment |
Expand Down
3 changes: 3 additions & 0 deletions charts/flyte-core/templates/admin/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,9 @@ spec:
{{- with .Values.flyteadmin.additionalVolumeMounts -}}
{{ tpl (toYaml .) $ | nindent 8 }}
{{- end }}
{{- with .Values.flyteadmin.additionalContainers -}}
{{- tpl (toYaml .) $ | nindent 6}}
{{- end }}
serviceAccountName: {{ template "flyteadmin.name" . }}
volumes: {{- include "databaseSecret.volume" . | nindent 8 }}
- emptyDir: {}
Expand Down
2 changes: 2 additions & 0 deletions charts/flyte-core/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,8 @@ flyteadmin:
secrets: {}
additionalVolumes: []
additionalVolumeMounts: []
# -- Appends additional containers to the containers list. May include template values.
additionalContainers: {}
# -- Appends extra command line arguments to the serve command
extraArgs: {}
# -- Sets priorityClassName for flyteadmin pod(s).
Expand Down

0 comments on commit 170e925

Please sign in to comment.